Skip to content

chore: remove duplicate caching layer #14988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benmccann merged 1 commit into from
Nov 26, 2025
+6 −12
Merged

chore: remove duplicate caching layer #14988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-crews-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/enhanced-img': patch
---

chore: remove duplicate caching layer
13 changes: 1 addition & 12 deletions packages/enhanced-img/src/vite-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ const OPTIMIZABLE = /^[^?]+\.(avif|heif|gif|jpeg|jpg|png|tiff|webp)(\?.*)?$/;
* @returns {import('vite').Plugin<void>}
*/
export function image_plugin(imagetools_plugin) {
// TODO: clear this map in dev mode to avoid memory leak
/**
* URL to image details
* @type {Map<string, import('vite-imagetools').Picture>}
*/
const images = new Map();

/** @type {import('vite').ResolvedConfig} */
let vite_config;

Expand Down Expand Up @@ -117,11 +110,7 @@ export function image_plugin(imagetools_plugin) {
}

if (OPTIMIZABLE.test(url)) {
let image = images.get(resolved_id);
if (!image) {
image = await process_id(resolved_id, plugin_context, imagetools_plugin);
images.set(resolved_id, image);
}
const image = await process_id(resolved_id, plugin_context, imagetools_plugin);
s.update(node.start, node.end, img_to_picture(content, node, image));
} else {
const metadata = await sharp(resolved_id).metadata();
Expand Down
Loading