Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/easy-plants-remain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: ensure `form` remote functions' `fields.set` triggers reactivity
13 changes: 13 additions & 0 deletions packages/kit/src/runtime/client/remote-functions/form.svelte.js
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,21 @@ export function form(id) {
(path, value) => {
if (path.length === 0) {
input = value;
update_all_versions();
} else {
input = deep_set(input, path.map(String), value);

const key = build_path_string(path);
versions[key] ??= 0;
versions[key] += 1;
touched[key] = true;

const parent_path = path.slice();
while (parent_path.pop() !== undefined) {
const parent_key = build_path_string(parent_path);
versions[parent_key] ??= 0;
versions[parent_key] += 1;
}
}
},
() => issues
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<script lang="ts">
import { set_message } from '../form.remote.js';
import * as v from 'valibot';

const schema = v.object({
message: v.picklist(
['hello', 'goodbye', 'unexpected error', 'expected error', 'redirect'],
'message is invalid'
)
});
</script>

<form {...set_message.preflight(schema)}>
<label>
<span>Message</span>
<input {...set_message.fields.message.as('text')} />
</label>

<p id="issue">
{set_message.fields.message.issues()?.[0]?.message ?? 'ok'}
</p>
<p id="value">{set_message.fields.message.value()}</p>

<button
id="set-and-validate"
type="button"
on:click={async () => {
set_message.fields.message.set('hello');
await set_message.validate({ includeUntouched: true });
}}
>
Set & validate
</button>
<button>Submit</button>
</form>
12 changes: 12 additions & 0 deletions packages/kit/test/apps/basics/test/client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1965,6 +1965,18 @@ test.describe('remote functions', () => {
await expect(page.locator('p')).toHaveText('success');
});

test('fields.set updates DOM before validate', async ({ page }) => {
await page.goto('/remote/form/imperative');

const input = page.locator('input[name="message"]');
await input.fill('123');

await page.locator('#set-and-validate').click();

await expect(input).toHaveValue('hello');
await expect(page.locator('#issue')).toHaveText('ok');
});

test('command pending state is tracked correctly', async ({ page }) => {
await page.goto('/remote');

Expand Down
Loading