Skip to content

fix: correctly resolve $app/state on the server with Vite 5 #13181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teemingc wants to merge 4 commits into from
Closed

fix: correctly resolve $app/state on the server with Vite 5 #13181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1252f55
fix...?
Dec 17, 2024
6f365f1
changeset
Dec 17, 2024
ef2110f
format and add comment
Dec 17, 2024
0c5ca07
Update packages/kit/src/exports/vite/index.js
teemingc Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-suns-fail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: correctly resolve `$app/state` on the server with Vite 5
8 changes: 7 additions & 1 deletion packages/kit/src/exports/vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,13 @@ async function kit({ svelte_config }) {
// See https://github.com/sveltejs/kit/pull/9172
// and https://vitest.dev/config/#deps-registernodeloader
'@sveltejs/kit'
]
],
resolve: {
// We need this so that importing $app/state correctly
// resolves to the default conditional export instead of
// the browser condition on the server.
conditions: ['module', 'node']
}
}
};

Expand Down
Loading