Skip to content

feat: redact internal stack trace when reporting config errors #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Dec 13, 2023
Merged

feat: redact internal stack trace when reporting config errors #11292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e37163
feat: redact internal stack trace when reporting config errors
Rich-Harris Dec 13, 2023
386fbb7
lint
Rich-Harris Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-crabs-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': minor
---

feat: redact internal stack trace when reporting config errors
10 changes: 9 additions & 1 deletion packages/kit/src/core/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,15 @@ export async function load_config({ cwd = process.cwd() } = {}) {

const config = await import(`${url.pathToFileURL(config_file).href}?ts=${Date.now()}`);

return process_config(config.default, { cwd });
try {
return process_config(config.default, { cwd });
} catch (e) {
const error = /** @type {Error} */ (e);

// redact the stack trace — it's not helpful to users
error.stack = `Could not load svelte.config.js: ${error.message}\n`;
throw error;
}
}

/**
Expand Down