-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: prerender optional parameters as empty when entries contains '*'
#11178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benmccann
merged 13 commits into
sveltejs:version-2
from
LorisSigrist:11133-crawl-optional-param-at-root
Dec 12, 2023
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5a67927
Prerender optional params without value
LorisSigrist 234cb59
Merge branch 'master' into 11133-crawl-optional-param-at-root
LorisSigrist d8c4bdf
Format, Lint & fix lockfile
LorisSigrist 4a8d717
Add changeset
LorisSigrist bcfe4dd
Update packages/kit/src/core/postbuild/prerender.js
LorisSigrist a32a5b3
Update .changeset/good-jars-relax.md
LorisSigrist e382995
Move test from own project into `prerendering/basics`
LorisSigrist 1b862f0
Merge remote-tracking branch 'origin/11133-crawl-optional-param-at-ro…
LorisSigrist d4697c9
Update KitConfig.entries description
LorisSigrist 24c4589
Hopefully fix test on ubuntu
LorisSigrist 02269ae
Update packages/kit/src/exports/public.d.ts
benmccann ff3ee54
Merge branch 'version-2' into 11133-crawl-optional-param-at-root
benmccann 37cfe14
update types
benmccann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sveltejs/kit': patch | ||
| --- | ||
|
|
||
| fix: prerender optional parameters as empty when `entries` contains `'*'` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/kit/test/prerendering/basics/src/routes/optional-params/[[optional]]/+page.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| <a href="/optional-params/with-value">Path with Value</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.