Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rawBody #1109

Merged
merged 17 commits into from
Apr 18, 2021
Merged

Expose rawBody #1109

merged 17 commits into from
Apr 18, 2021

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 18, 2021

This closes #831, making rawBody available to getContext, handle and endpoints.

It also derives request.body from request.rawBody inside Kit, rather than making adapters jump through hoops. This will make it easier to build lambda-based adapters, for example.

  • update docs
  • update adapter-begin (though i'm not sure what state this is in currently) will do this in a follow-up
  • update adapter-cloudflare-workers
  • update adapter-netlify
  • update adapter-vercel
  • add test of reading rawBody
  • figure out API details. parse_body doesn't need to be exposed outside the package, but get_raw_body probably does, in some form. is @sveltejs/kit/http the right place for it? We typically defer to JS ecosystem conventions for public APIs, so it probably ought to be getRawBody

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Apr 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit-demo/H1o896gH4NQvES2fAQTAyCe4Hbpp
✅ Preview: https://kit-demo-git-gh-831-sveltejs1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get raw request body in endpoint
1 participant