Skip to content

fix: correctly configure module and noEmit tsconfig and jsconfig properties #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 14, 2023
Merged

fix: correctly configure module and noEmit tsconfig and jsconfig properties #11029

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f0d317
add module NodeNext to tsconfig.json for library projects
eltigerchino Nov 13, 2023
947128b
add noEmit
eltigerchino Nov 13, 2023
5e4515f
reword changeset
eltigerchino Nov 13, 2023
dde37b2
add to generated tsconfig instead
eltigerchino Nov 13, 2023
c3a9595
use moduleResolution bundler instead
eltigerchino Nov 13, 2023
f8d7bb1
cleanup
dummdidumm Nov 14, 2023
f6c6428
Update packages/create-svelte/shared/+skeletonlib+typescript/tsconfig…
dummdidumm Nov 14, 2023
987e572
Update packages/kit/src/core/sync/write_tsconfig.js
dummdidumm Nov 14, 2023
391c8a4
add module nodenext
dummdidumm Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perfect-seahorses-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-svelte': patch
---

fix: correctly configure `module` and `noEmit` tsconfig and jsconfig properties
3 changes: 2 additions & 1 deletion packages/create-svelte/shared/+checkjs/jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"resolveJsonModule": true,
"skipLibCheck": true,
"sourceMap": true,
"strict": true
"strict": true,
"moduleResolution": "bundler"
}
// Path aliases are handled by https://kit.svelte.dev/docs/configuration#alias and https://kit.svelte.dev/docs/configuration#files
//
Expand Down
2 changes: 1 addition & 1 deletion packages/create-svelte/shared/+skeletonlib+typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"skipLibCheck": true,
"sourceMap": true,
"strict": true,
"moduleResolution": "NodeNext"
"moduleResolution": "bundler"
}
}
3 changes: 2 additions & 1 deletion packages/create-svelte/shared/+typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"resolveJsonModule": true,
"skipLibCheck": true,
"sourceMap": true,
"strict": true
"strict": true,
"moduleResolution": "bundler"
}
// Path aliases are handled by https://kit.svelte.dev/docs/configuration#alias
//
Expand Down
0 ...te/templates/skeletonlib/src/lib/index.js → ...te/templates/skeletonlib/src/lib/index.ts
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/kit/src/core/sync/write_tsconfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export function get_tsconfig(kit, include_base_url) {
lib: ['esnext', 'DOM', 'DOM.Iterable'],
moduleResolution: 'node',
module: 'esnext',
noEmit: true, // prevent tsconfig error "overwriting input files" - Vite handles the build and ignores this
target: 'esnext',

// TODO(v2): use the new flag verbatimModuleSyntax instead (requires support by Vite/Esbuild)
Expand Down