Skip to content

fix: ensure ssrRewriteStacktrace doesn't throw #10638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paoloricciuti wants to merge 4 commits into from
Closed

fix: ensure ssrRewriteStacktrace doesn't throw #10638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
113dfc5
ensure ssrRewriteStacktrace doesn't throw
paoloricciuti Aug 28, 2023
40e1e5a
Create wicked-planes-approve.md
paoloricciuti Aug 28, 2023
77ad670
fix lint
paoloricciuti Aug 28, 2023
afaa26d
Update .changeset/wicked-planes-approve.md
paoloricciuti Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-planes-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sveltejs/kit": patch
---

fix: ensure ssrRewriteStacktrace doesn't throw
6 changes: 5 additions & 1 deletion packages/kit/src/exports/vite/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,11 @@ export async function dev(vite, vite_config, svelte_config) {

/** @param {string} stack */
function fix_stack_trace(stack) {
return stack ? vite.ssrRewriteStacktrace(stack) : stack;
try {
return stack ? vite.ssrRewriteStacktrace(stack) : stack;
} catch (_e) {
return stack;
}
}

await update_manifest();
Expand Down