Skip to content

fix: Stop warning users that crons don't match paths when they actually do #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Jun 1, 2023
Merged

fix: Stop warning users that crons don't match paths when they actually do #10074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f1d2eb
fix: stop warning about friendly crons
elliott-with-the-longest-name-on-github May 31, 2023
04fcf8d
changeset
elliott-with-the-longest-name-on-github May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-balloons-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-vercel': patch
---

fix: stop incorrectly warning users that crons don't match paths
8 changes: 2 additions & 6 deletions packages/adapter-vercel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,13 +575,9 @@ function validate_vercel_json(builder, vercel_config) {
continue;
}

for (const route of valid_routes) {
if (route.pattern.test(path)) {
continue;
}
if (!valid_routes.some((route) => route.pattern.test(path))) {
unmatched_paths.push(path);
}

unmatched_paths.push(path);
}

if (unmatched_paths.length) {
Expand Down