Skip to content

fix: Always add Storybook last #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

fix: Always add Storybook last #547

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0b696c
fix: always handle storybook as the last addon
JReinhold Apr 24, 2025
a16ce99
Add changesets
JReinhold Apr 24, 2025
1dbb138
Update packages/cli/lib/install.ts
manuel3108 Apr 24, 2025
3d5f1f7
fix lint
manuel3108 Apr 24, 2025
7344eff
fix changeset
manuel3108 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-rivers-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

Always add Storybook after all other addons
7 changes: 6 additions & 1 deletion packages/cli/lib/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ async function runAddon({ addon, multiple, workspace }: RunAddon) {
// but works for now in contrary to the previouse implementation
function orderAddons(addons: Array<Addon<any>>, setupResults: Record<string, AddonSetupResult>) {
return addons.sort(
(a, b) => setupResults[a.id]?.dependsOn?.length - setupResults[b.id]?.dependsOn?.length
(a, b) => {
// Adding storybook last means it will correctly detect and integrate with other addons like vitest and eslint
if (a.id === 'storybook') return 1;
if (b.id === 'storybook') return -1;
return setupResults[a.id]?.dependsOn?.length - setupResults[b.id]?.dependsOn?.length;
}
);
}