Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to storybook 8.3.0 #22

Closed
wants to merge 1 commit into from
Closed

upgrade to storybook 8.3.0 #22

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Sep 12, 2024

I'd thought there might have also been a workaround for storybook somewhere, but can't remember if all we did was pin this version?

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-manipulation@22
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@22
pnpm add https://pkg.pr.new/sveltejs/cli/sv@22
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@22

commit: 4759949

Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're still facing the same issue where the dependencies are still not being added

main branch:

  "devDependencies": {
    "@sveltejs/adapter-auto": "^3.0.0",
    "@sveltejs/kit": "^2.0.0",
    "@sveltejs/vite-plugin-svelte": "^4.0.0-next.6",
    "svelte": "^5.0.0-next.1",
    "svelte-check": "^4.0.0",
    "typescript": "^5.0.0",
    "vite": "^5.0.3",
    "storybook": "8.3.0-alpha.3",
    "@storybook/svelte": "8.3.0-alpha.3",
    "@storybook/sveltekit": "8.3.0-alpha.3",
    "@storybook/blocks": "8.3.0-alpha.3",
    "@storybook/addon-svelte-csf": "^4.1.7",
    "@storybook/addon-links": "8.3.0-alpha.3",
    "@storybook/addon-essentials": "8.3.0-alpha.3",
    "@chromatic-com/storybook": "^1.9.0",
    "@storybook/test": "8.3.0-alpha.3",
    "@storybook/addon-interactions": "8.3.0-alpha.3"
  },

this PR:

  "devDependencies": {
    "@sveltejs/adapter-auto": "^3.0.0",
    "@sveltejs/kit": "^2.0.0",
    "@sveltejs/vite-plugin-svelte": "^4.0.0-next.6",
    "svelte": "^5.0.0-next.1",
    "svelte-check": "^4.0.0",
    "typescript": "^5.0.0",
    "vite": "^5.0.3",
    "@storybook/addon-svelte-csf": "^4.1.7",
    "@chromatic-com/storybook": "^1.9.0"
  },

I don't know how this keeps happening where only the prereleases do this correctly and the latest doesn't 😅

@benmccann
Copy link
Member Author

oh goodness. glad you tested. I filed storybookjs/storybook#29112, so will close this for now

@benmccann benmccann closed this Sep 13, 2024
@benmccann benmccann deleted the storybook-8.3 branch September 13, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants