-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
讓 UserScript 和擴充版本使用同一份腳本 #17
Draft
bluenk
wants to merge
15
commits into
suzumiyahifumi:main
Choose a base branch
from
bluenk:feat-userscript-adapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added an async method.
bluenk
commented
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我不知道為什麼它認為整個檔案都被換掉了,不過這邊的內容和 userscript 版本是完全一樣的。
This manifest config will cause both firefox and chrome to show warning, although it is save to ignore, but it may get reject when reviewing. See https://stackoverflow.com/a/78088358 's comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
FantiaDownloader.js
?background.js
能夠在 service worker 運作改動
inject.js
FantiaDownloader.js
運作於擴充版本中時:URL.createObjectURL
會被無效化,直接將 blob 傳到 background script。GM*
函式會使用userscriptAdapter.js
內的同名函式