feat(coordination): dynamic plugin loader (ADR-028 D6) [#1420]

[susumutomita]

Summary

#1606 が coordination dispatcher core(state store + dispatchCoordinationOp / projectCoordinationForTeam)をマージしたが、問題が同梱する CoordinationPlugin を runtime に取得する loader が欠けていた。ADR-028 D6(「plugin module を S3 = ADR-008 payload 経路から fetch + import() で動的 load」)の loader 部分を実装する。

静的レジストリではなく動的 import を採る理由: community が coordination 付き問題を後から追加するたびに platform を再デプロイせずに済むため。静的だと platform が各問題に結合し、「問題は plugin、platform は host」を壊して問題カタログの community moat を殺す。

coordination-plugin-loader.ts

• isCoordinationPlugin — 動的 load した未知 module が SDK 契約(initialState + 3 必須 hook、tick は optional)を満たすか構造判定する門番。
• loadCoordinationPlugin(importer, ref) — import 関数を 注入(本番は S3 materialize 後の module、test は fake)。import 失敗 / 契約不一致は null を返し、caller が safe fallback。
• loadAndDispatchCoordinationOp / loadAndProjectCoordinationForTeam — 動的 load → 既存 feat(coordination): dispatcher core — state store + orchestration (ADR-028 D3/D6) #1606 dispatcher への委譲を 1 経路にした orchestration。load 不可は plugin_unavailable / fallbackProjection で participant API を壊さない。

別 isolate sandbox は立てない(ADR-028 D6、cost/複雑度): plugin の hook は SDK 契約上すべて純関数で、bug は当該 event の 1 row に閉じる(optimistic lock + DDB write fail で停止)。

Test plan

• coordination-plugin-loader.test.ts 12 test、loader file 100%(17/17 stmts, 16/16 branch, 4/4 func, 14/14 lines)。
• 純追加(新 file + 新 test のみ、既存 source 無改変)→ infra 全体 2278 test 緑(従来 2266 + 12)。
• typecheck 0 / biome clean / make harness no findings(INVARIANT_PR_SHIPS_WORKING_INCREMENT 含む違反なし)。

Regression analysis

• 既存 source を一切変更しないため既存挙動は不変。loader は import 関数を DI 境界に置いたので、意味論は S3 経路の有無と独立に検証済み。
• scope 外(= 次 increment): 実 importer(S3 から plugin を materialize)と HTTP route 配線(POST /portal/me/coordination/op + GET /projection、auth/event-scope 解決)。

Physical impact

• NO-OP on CFn / deployed artifacts。participant-handler Lambda の source に純関数 module を追加するのみ(新 IAM / table / env なし)。

Relates #1420

[coderabbitai]

Warning

Review limit reached

@susumutomita, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9bdb8f88-3ade-4a56-a3de-72e647523306

📥 Commits

Reviewing files that changed from the base of the PR and between 3938f87 and d01fc50.

📒 Files selected for processing (2)

• infrastructure/lib/problem-deploy/handlers/participant-handler/coordination-plugin-loader.ts
• infrastructure/test/problem-deploy/coordination-plugin-loader.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/coordination-plugin-loader

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (3938f87) to head (d01fc50).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         382      383    +1     
  Lines       10460    10475   +15     
  Branches     3200     3206    +6     
=======================================
+ Hits         9755     9770   +15     
  Misses        217      217           
  Partials      488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.