Skip to content

chore(harness): ban Unicorn.Rentals (AWS GameDay IP) + rename to Tenryu.Mart - #1377

Merged
susumutomita merged 1 commit into
mainfrom
chore/ban-aws-gameday-fiction-names
May 26, 2026
Merged

susumutomita merged 1 commit into
mainfrom
chore/ban-aws-gameday-fiction-names

Conversation

@susumutomita

Copy link
Copy Markdown
Owner

Summary

Unicorn.Rentals は AWS GameDay の registered fictional company。 OSS / 商用配布する競技 platform 側で使うのは AWS Training の derivative work と見なされかねない IP リスク。

  1. Harness rule no-aws-trademark-fictions で Unicorn.Rentals / Unicorn Rentals (case-insensitive) を block。 例外は // allow-aws-fiction: / <!-- allow-aws-fiction: --> で明示。
  2. Submodule rename (TenkaCloudChallenge#27 + update AGENTS.md #28 merged): Unicorn.Rentals → Tenryu.Mart (天龍 = 天下一武道会 flavor)。
  3. Submodule pin を bedde98 に bump。
  4. README.md catalog 行を Tenryu.Mart に更新。
  5. docs/lore/world.html から AWS GameDay の name-drop を削除、 「独自 lore を別に持つ理由」 を harness rule とセットで説明。

Regression analysis

  • 8 new harness rule tests pass、 全 63 harness rule tests green
  • Unicorn substring は tracked file から完全に消去 (rule 自体の comment のみ allow marker で exempt)
  • runtime / SPA / CFn の動作変更なし
  • check-template-cfn-refs / check-template-security / validate-problems 全部 green

Physical impact

NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule rename) + README + lore HTML + 新規 harness rule のみ。

…yu.Mart

## Why

Unicorn.Rentals is AWS GameDay's registered fictional e-commerce company.
Reusing it in an OSS / commercial competition platform invites IP risk.

## What

1. **Harness rule `no-aws-trademark-fictions`** flags `Unicorn.Rentals` /
   `Unicorn Rentals` (case-insensitive) in tracked text files. Exemption
   via `// allow-aws-fiction:` / `<!-- allow-aws-fiction: -->` markers.
2. **Submodule rename** (PRs #27 + #28 merged): `Unicorn.Rentals` →
   `Tenryu.Mart` (天龍 — Heaven-Dragon — fits the 天下一武道会 lore).
3. **Submodule pin bumped** to bedde98.
4. **README.md** catalog row updated.
5. **docs/lore/world.html** drops the AWS GameDay name-drop; explains the
   deliberate separation and points at the harness rule.

## Regression analysis

- 8 new harness rule tests pass; all 63 harness rule tests green.
- `Unicorn` substring no longer in any tracked file except the rule's own
  index.ts comment (exempted by the documented allow marker).
- No runtime behavior changes.

## Physical impact

NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule), README, lore
HTML, and one new harness rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@susumutomita, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b6291e66-620e-471c-865c-eac17fec59af

📥 Commits

Reviewing files that changed from the base of the PR and between 810964c and 330764d.

📒 Files selected for processing (6)
  • .claude/harness/src/rules/index.ts
  • .claude/harness/src/rules/no-aws-trademark-fictions.test.ts
  • .claude/harness/src/rules/no-aws-trademark-fictions.ts
  • README.md
  • docs/lore/world.html
  • problems
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ban-aws-gameday-fiction-names

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@susumutomita
susumutomita enabled auto-merge (squash) May 26, 2026 05:40
@susumutomita
susumutomita merged commit 51d5901 into main May 26, 2026
8 checks passed
@susumutomita
susumutomita deleted the chore/ban-aws-gameday-fiction-names branch May 26, 2026 05:44
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@810964c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage        ?   65.71%           
=======================================
  Files           ?      369           
  Lines           ?    10462           
  Branches        ?     3298           
=======================================
  Hits            ?     6875           
  Misses          ?     2561           
  Partials        ?     1026           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

susumutomita added a commit that referenced this pull request May 27, 2026
* chore(harness): ban Unicorn.Rentals (AWS GameDay IP) + rename to Tenryu.Mart

## Why

Unicorn.Rentals is AWS GameDay's registered fictional e-commerce company.
Reusing it in an OSS / commercial competition platform invites IP risk.

## What

1. **Harness rule `no-aws-trademark-fictions`** flags `Unicorn.Rentals` /
   `Unicorn Rentals` (case-insensitive) in tracked text files. Exemption
   via `// allow-aws-fiction:` / `<!-- allow-aws-fiction: -->` markers.
2. **Submodule rename** (PRs #27 + #28 merged): `Unicorn.Rentals` →
   `Tenryu.Mart` (天龍 — Heaven-Dragon — fits the 天下一武道会 lore).
3. **Submodule pin bumped** to bedde98.
4. **README.md** catalog row updated.
5. **docs/lore/world.html** drops the AWS GameDay name-drop; explains the
   deliberate separation and points at the harness rule.

## Regression analysis

- 8 new harness rule tests pass; all 63 harness rule tests green.
- `Unicorn` substring no longer in any tracked file except the rule's own
  index.ts comment (exempted by the documented allow marker).
- No runtime behavior changes.

## Physical impact

NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule), README, lore
HTML, and one new harness rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(submodule): bump catalog to 57a2855 (dragons endpoint rename)

Picks up TenkaCloudChallenge#29 — the `/api/v1/unicorns` → `/api/v1/dragons`
follow-up to PR #1377 that finished removing AWS GameDay carryover branding.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant