Repository navigation
chore(harness): ban Unicorn.Rentals (AWS GameDay IP) + rename to Tenryu.Mart - #1377
Conversation
…yu.Mart ## Why Unicorn.Rentals is AWS GameDay's registered fictional e-commerce company. Reusing it in an OSS / commercial competition platform invites IP risk. ## What 1. **Harness rule `no-aws-trademark-fictions`** flags `Unicorn.Rentals` / `Unicorn Rentals` (case-insensitive) in tracked text files. Exemption via `// allow-aws-fiction:` / `<!-- allow-aws-fiction: -->` markers. 2. **Submodule rename** (PRs #27 + #28 merged): `Unicorn.Rentals` → `Tenryu.Mart` (天龍 — Heaven-Dragon — fits the 天下一武道会 lore). 3. **Submodule pin bumped** to bedde98. 4. **README.md** catalog row updated. 5. **docs/lore/world.html** drops the AWS GameDay name-drop; explains the deliberate separation and points at the harness rule. ## Regression analysis - 8 new harness rule tests pass; all 63 harness rule tests green. - `Unicorn` substring no longer in any tracked file except the rule's own index.ts comment (exempted by the documented allow marker). - No runtime behavior changes. ## Physical impact NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule), README, lore HTML, and one new harness rule. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 3 minutes and 26 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
=======================================
Coverage ? 65.71%
=======================================
Files ? 369
Lines ? 10462
Branches ? 3298
=======================================
Hits ? 6875
Misses ? 2561
Partials ? 1026 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* chore(harness): ban Unicorn.Rentals (AWS GameDay IP) + rename to Tenryu.Mart ## Why Unicorn.Rentals is AWS GameDay's registered fictional e-commerce company. Reusing it in an OSS / commercial competition platform invites IP risk. ## What 1. **Harness rule `no-aws-trademark-fictions`** flags `Unicorn.Rentals` / `Unicorn Rentals` (case-insensitive) in tracked text files. Exemption via `// allow-aws-fiction:` / `<!-- allow-aws-fiction: -->` markers. 2. **Submodule rename** (PRs #27 + #28 merged): `Unicorn.Rentals` → `Tenryu.Mart` (天龍 — Heaven-Dragon — fits the 天下一武道会 lore). 3. **Submodule pin bumped** to bedde98. 4. **README.md** catalog row updated. 5. **docs/lore/world.html** drops the AWS GameDay name-drop; explains the deliberate separation and points at the harness rule. ## Regression analysis - 8 new harness rule tests pass; all 63 harness rule tests green. - `Unicorn` substring no longer in any tracked file except the rule's own index.ts comment (exempted by the documented allow marker). - No runtime behavior changes. ## Physical impact NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule), README, lore HTML, and one new harness rule. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(submodule): bump catalog to 57a2855 (dragons endpoint rename) Picks up TenkaCloudChallenge#29 — the `/api/v1/unicorns` → `/api/v1/dragons` follow-up to PR #1377 that finished removing AWS GameDay carryover branding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Unicorn.Rentals は AWS GameDay の registered fictional company。 OSS / 商用配布する競技 platform 側で使うのは AWS Training の derivative work と見なされかねない IP リスク。
no-aws-trademark-fictionsでUnicorn.Rentals/Unicorn Rentals(case-insensitive) を block。 例外は// allow-aws-fiction:/<!-- allow-aws-fiction: -->で明示。Unicorn.Rentals→Tenryu.Mart(天龍 = 天下一武道会 flavor)。bedde98に bump。Tenryu.Martに更新。Regression analysis
Unicornsubstring は tracked file から完全に消去 (rule 自体の comment のみ allow marker で exempt)check-template-cfn-refs/check-template-security/validate-problems全部 greenPhysical impact
NO-OP for CFn / Lambda / IAM. Catalog metadata (submodule rename) + README + lore HTML + 新規 harness rule のみ。