make strategy mandatory

surjithctly · Jun 4, 2024 · 36d1751 · 36d1751
1 parent db95add
commit 36d1751
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "astro-color-scheme",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "Perfect dark mode for Astro in few lines of code. Theme Toggle for Dark, Light & Auto (system)",
   "type": "module",
   "exports": {
@@ -17,7 +17,17 @@
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },
-  "keywords": ["astro", "astro-component", "themes", "color-scheme", "dark", "dark-mode", "light", "system", "auto"],
+  "keywords": [
+    "astro",
+    "astro-component",
+    "themes",
+    "color-scheme",
+    "dark",
+    "dark-mode",
+    "light",
+    "system",
+    "auto"
+  ],
   "author": "Surjith S M",
   "license": "MIT"
 }
diff --git a/src/ThemeSwitch.astro b/src/ThemeSwitch.astro
@@ -1,9 +1,9 @@
 ---
-type Props = Partial<{
-  as: "div" | "span";
-  defaultTheme: "dark" | "light" | "system";
+type Props = {
   strategy: "button" | "checkbox" | "select" | "radio";
-}>;
+  as?: "div" | "span";
+  defaultTheme?: "dark" | "light" | "system";
+};
 
 const { strategy, defaultTheme, as: Element = "span" }: Props = Astro.props;
 ---
@@ -69,6 +69,12 @@ const { strategy, defaultTheme, as: Element = "span" }: Props = Astro.props;
     element.addEventListener(eventType, themeUpdater);
   }
 
+  if (!strategy) {
+      throw new Error(
+        `plugin-astro-color-scheme: Please add a 'strategy' attribute to <ThemeSwitch/>`
+      );
+    }
+
   switch (strategy) {
     case "button":
       setupThemeSwitch("button", "click", (event) => {