New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Telemetry 1.x warning caused by local function capture #9

Merged

kamilkowalski merged 1 commit into surgeventures:main from nallwhy:fix_telemetry_warning

Dec 6, 2021

Contributor

nallwhy commented Dec 6, 2021

This PR fixes the warning from telemetry below.

Function passed as a handler with ID {TelemetryMetricsAppsignal, [:worker], #PID<0.1478.0>} is local function.
This mean that it is either anonymous function or capture of function without module specified. That may cause performance penalty when calling such handler. For more details see note in `telemetry:attach/4` documentation.

https://hexdocs.pm/telemetry/telemetry.html#attach-4


          Fix Telemetry 1.x warning caused by local function capture

c3d3203

Member

kamilkowalski commented Dec 6, 2021

Great catch @nallwhy! 👏

kamilkowalski approved these changes

View reviewed changes

kamilkowalski merged commit 5235c48 into surgeventures:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet