feat: oauth - WIP #158
Merged
feat: oauth - WIP #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Jul 30, 2024
|
|
||
| import java.util.List; | ||
|
|
||
| public class OAuthAuthResponse { |
Contributor
There was a problem hiding this comment.
only classes that are used in this interface should be declared in here. Rest go in the core. I don't see this class being used in the interface, therefore it should go in the core.
Contributor
Author
There was a problem hiding this comment.
Oh, okay. Got it!
sattvikc
added a commit
that referenced
this pull request
Oct 4, 2024
* fix: tenant config * fix: thirdparty providers * fix: cleanup * fix: providers non null * fix: changelog * fix: pr comments * reformats code * adds function to check if client exists for the app * feat: oauth - WIP (#158) * feat: oauth recipe id, sqlstoreage and response type * fix: review fixes * fix: review fixes * fix: review fix - renamed exception * feat: OAuthStorage isClientAlreadyExists * feat: delete from oauth table * fix: removing unused/unnecessary method, change return type of other * fix: merge with latest (#159) * adding dev-v6.2.0 tag to this commit to ensure building * adding dev-v6.2.0 tag to this commit to ensure building * fix: listClientsForApp * fix: oauth plugin interface updates (#160) * fix: revoke * fix: pr comments * fix: oauth storage * fix: update * fix: add m2m token * fix: revoke and cleanup * fix: logout (#161) * fix: logout * fix: session revoke in logout * fix: version and cleanup * fix: rename / refactor * fix: changelog * fix: changelog * fix: constraints --------- Co-authored-by: rishabhpoddar <[email protected]> Co-authored-by: Tamas Soltesz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Checklist for important updates
build.gradlegit tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR