fix(desktop): respect preset execution mode when using hotkeys

[chasemcdo]

Summary

• Preset hotkeys (Ctrl+1-9) now correctly execute commands in parallel when the preset's executionMode is set to "parallel", matching the behavior of the dropdown menu
• Extracted shared openPreset function into useTabsWithPresets hook to consolidate preset-opening logic

Problem

The hotkey handler always called addTab which creates a single pane and joins commands with && (sequential execution), ignoring the preset's executionMode setting. The dropdown menu correctly handled this by checking the execution mode and calling addTabWithMultiplePanes for parallel presets.

Test plan

• Create a preset with multiple commands and executionMode: "parallel"
• Open via dropdown menu: commands execute in parallel (separate panes)
• Open via hotkey (Ctrl+1): commands also execute in parallel (separate panes)
• Verify sequential presets still work correctly via both paths

Summary by CodeRabbit

• Improvements

  • Streamlined workspace preset operations with a unified preset-opening mechanism that consolidates multiple manual steps and conditional logic into a single, consistent action across all workspace components.

• Refactor

  • Simplified preset-handling code by eliminating redundant operations and reorganizing how workspace presets are created, opened, and managed throughout the application for improved consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR introduces an openPreset method to the useTabsWithPresets hook that consolidates preset tab creation logic. This method replaces scattered manual tab construction and renaming operations previously distributed across WorkspacePage and GroupStrip components, handling both single and multi-pane preset modes.

Changes

Cohort / File(s)	Summary
Hook implementation apps/desktop/src/renderer/stores/tabs/useTabsWithPresets.ts	Added openPreset(workspaceId, preset) method that handles single vs. multi-pane tab creation based on preset execution mode, performs optional tab renaming, and returns the created tab ID. Imports TerminalPreset type and memoizes the new method with internal store dependencies.
Component consumers apps/desktop/src/renderer/routes/_authenticated/_dashboard/workspace/$workspaceId/page.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx	Updated to consume the new openPreset API instead of inline preset handling. Removed local tab construction logic, renaming state, and addTabWithMultiplePanes branching; replaced with single openPreset() calls. Simplified handleSelectPreset signature in GroupStrip.

Sequence Diagram

sequenceDiagram
    actor User
    participant WorkspacePage/GroupStrip as Component:<br/>WorkspacePage/<br/>GroupStrip
    participant openPreset as openPreset Method
    participant storeActions as Store Actions:<br/>storeAddTab/<br/>storeAddTabWithMultiplePanes
    participant renameTab as renameTab

    User->>WorkspacePage/GroupStrip: Select preset
    WorkspacePage/GroupStrip->>openPreset: openPreset(workspaceId, preset)
    alt preset.executionMode === "parallel"<br/>AND commands.length > 1
        openPreset->>storeActions: storeAddTabWithMultiplePanes(...)
    else Single pane mode
        openPreset->>storeActions: storeAddTab(...)
    end
    storeActions-->>openPreset: tabId
    alt preset.name provided
        openPreset->>renameTab: renameTab(tabId, preset.name)
        renameTab-->>openPreset: ✓
    end
    openPreset-->>WorkspacePage/GroupStrip: { tabId }

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat(desktop): add preset keyboard shortcuts and drag-and-drop reordering #939: Directly overlaps in preset-driven tab creation logic and openTabWithPreset hotwiring in WorkspacePage.
• feat(desktop): add userTitle field for user-renamed tabs #289: Intersects with renameTab handling changes in the tabs store that openPreset depends on.
• feat(desktop): add default preset support for new terminals #637: Concurrent modifications to the useTabsWithPresets hook and preset integration across GroupStrip and WorkspacePage.

Suggested reviewers

• saddlepaddle

Poem

🐰 Presets now flow through a single door,
No scattered logic to balance anymore!
openPreset handles the dance—
Single pane or parallel's chance,
Tab creation streamlined to the core. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(desktop): respect preset execution mode when using hotkeys' accurately describes the main change: fixing hotkey behavior to respect preset execution modes.
Description check	✅ Passed	The pull request description comprehensively addresses the PR objectives, including the problem statement, solution approach, and detailed test plan with verification steps.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chasemcdo]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

[Kitenite]

Love a good refactor!