Skip to content

fix(desktop): rebind preset hotkeys from Cmd+Shift+Number to Ctrl+Number#993

Merged
Kitenite merged 2 commits intomainfrom
kiet-ho/rebind-preset-hotkeys
Jan 27, 2026
Merged

fix(desktop): rebind preset hotkeys from Cmd+Shift+Number to Ctrl+Number#993
Kitenite merged 2 commits intomainfrom
kiet-ho/rebind-preset-hotkeys

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 27, 2026

Summary

  • Rebinds preset hotkeys from Cmd+Shift+1-9 to Ctrl+1-9
  • Fixes conflict with macOS screenshot shortcuts (Cmd+Shift+3/4/5)
  • Follows familiar Chrome tab-switching pattern

Test plan

  • Verify Ctrl+1-9 opens corresponding presets
  • Verify macOS screenshot shortcuts (Cmd+Shift+3/4/5) work normally

Summary by CodeRabbit

  • Bug Fixes
    • Updated keyboard shortcuts for opening presets 1-9. The hotkey combinations have been changed to Ctrl+1 through Ctrl+9, replacing the previous modifier key combinations across the desktop application.

✏️ Tip: You can customize this high-level summary in your review settings.

Cmd+Shift+3/4/5 conflict with macOS screenshot shortcuts. Ctrl+Number
is available and follows the familiar Chrome tab-switching pattern.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 27, 2026

Warning

Rate limit exceeded

@Kitenite has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

This PR modifies 9 preset hotkey definitions in the shared hotkeys configuration, changing their key combinations from meta+shift+N (macOS convention) to ctrl+N (Windows/Linux convention) for presets 1 through 9, with no changes to other hotkey properties or logic.

Changes

Cohort / File(s) Summary
Preset Hotkey Keybindings
apps/desktop/src/shared/hotkeys.ts
Changed key modifiers for OPEN_PRESET_1 through OPEN_PRESET_9 from meta+shift+<digit> to ctrl+<digit> (9 hotkey definitions updated with identical pattern)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 The presets dance to a new tune,
No more meta+shift in the afternoon!
With ctrl+digits, snappy and bright,
Cross-platform harmony feels just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes a clear summary and test plan, but is missing several required template sections like Related Issues, Type of Change, Testing details, Screenshots, and Additional Notes. Complete the PR description by filling in the missing template sections, particularly the Type of Change section (should be 'Bug fix') and expanding the Testing section with detailed verification steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: rebinding preset hotkeys from Cmd+Shift+Number to Ctrl+Number, which matches the actual file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Fix hook call order by using wrapper pattern - outer component checks
if hotkeyId exists before rendering inner component that calls hook.
@Kitenite Kitenite merged commit 0943bff into main Jan 27, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

@Kitenite Kitenite deleted the kiet-ho/rebind-preset-hotkeys branch January 27, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant