fix (desktop): ctrl-d fix to kill terminal pane

[AviPeltz]

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Terminal now properly detects and responds to Ctrl+D (EOF) input, automatically closing the session when a clean exit occurs. This improves compatibility with standard terminal workflows.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

---

[coderabbitai]

📝 Walkthrough

Walkthrough

This change adds Ctrl+D (EOF) detection to the Terminal component, introducing a ref to track when Ctrl+D is sent and using it to automatically close the terminal pane when the exit code is 0 and the process wasn't forcefully killed.

Changes

Cohort / File(s)	Summary
Terminal Ctrl+D ref tracking apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx	Introduces ctrlDSentRef to track EOF signals and passes it as a dependency to useTerminalStream hook.
Terminal stream exit handler apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/hooks/useTerminalStream.ts	Extends UseTerminalStreamOptions interface with ctrlDSentRef, implements auto-close logic in handleTerminalExit to remove the pane when Ctrl+D is sent with exit code 0 and process wasn't killed by user, and resets the ref after handling.

Sequence Diagram

sequenceDiagram
    actor User
    participant Terminal
    participant useTerminalStream
    participant TabsStore

    User->>Terminal: Sends Ctrl+D (0x04)
    Terminal->>Terminal: Detects data === "\x04"
    Terminal->>Terminal: Sets ctrlDSentRef.current = true
    
    Note over Terminal,useTerminalStream: Terminal process exits with code 0
    
    useTerminalStream->>useTerminalStream: handleTerminalExit triggered
    useTerminalStream->>useTerminalStream: Check: exitCode === 0?
    useTerminalStream->>useTerminalStream: Check: ctrlDSentRef.current === true?
    useTerminalStream->>useTerminalStream: Check: wasKilledByUser === false?
    
    alt All conditions met
        useTerminalStream->>TabsStore: removePane(paneId)
        TabsStore->>TabsStore: Close terminal pane
    else Condition not met
        useTerminalStream->>useTerminalStream: Reset ctrlDSentRef.current = false
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor(desktop): Split Terminal component into smaller modules #838: Introduces the useTerminalStream hook that this PR extends with Ctrl+D tracking and auto-close logic.
• xterm ui #115: Also modifies the Terminal component in the same directory, related to terminal UI/functionality improvements.

Suggested reviewers

• Kitenite

Poem

🐰 A ref to track when Ctrl+D's sent,
Through streams it flows, heaven-bent,
Auto-close when exit's clean,
Terminal tabs bid adieu serene,
The signal echo'd, the pane is rest! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description follows the required template structure but lacks substantive content in critical sections like Description, Related Issues, and Testing.	Add a clear description of the changes, link any related issues using GitHub keywords, and document the testing steps performed to verify the Ctrl+D terminal pane fix.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing Ctrl+D functionality to properly kill/close the terminal pane, which matches the code changes introducing ctrlDSentRef tracking.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

[Kitenite]

Closing: stale fix from Jan 26 with no recent activity. Terminal handling has been reworked since.

[Kitenite]

Hey — just a heads up, this was closed as part of an automated stale PR cleanup. If you think this was done in error, feel free to reopen it!

[Kitenite]

Hey — this was closed by an automated cleanup of PRs with major merge conflicts that are 3+ weeks old. If you think this was done incorrectly, please feel free to reopen it. Sorry for any inconvenience!