Skip to content

Add more types#97

Merged
Kitenite merged 1 commit intomainfrom
cli-types-1
Nov 18, 2025
Merged

Add more types#97
Kitenite merged 1 commit intomainfrom
cli-types-1

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Nov 18, 2025

Summary by CodeRabbit

  • Chores
    • Reorganized type definitions across dedicated modules for improved code modularity.
    • Updated TypeScript configuration for consistency.
    • Added type definitions for environments, workspaces, processes, and agents to establish foundational abstractions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors CLI type definitions by extracting Environment, Workspace, and Process types into dedicated modules and restructuring the index.ts export layer to re-export from these modules. Updates TypeScript configuration to use a new base config and adjusts compiler options.

Changes

Cohort / File(s) Summary
Type Definition Modules
apps/cli/src/types/environment.ts, apps/cli/src/types/workspace.ts, apps/cli/src/types/process.ts
New files introducing modular type system with Environment/Workspace/Process interfaces and their corresponding Orchestrator interfaces (CRUD operations, async methods). Process module includes ProcessType, Terminal, AgentType, and Agent enums/interfaces. Workspace module includes WorkspaceType enum and LocalWorkspace extension.
Type Index Refactoring
apps/cli/src/types/index.ts
Replaces inline type declarations with consolidated re-exports from environment, workspace, and process modules. Removes previously exported Environment, Workspace, LocalWorkspace, Process, Terminal, Agent, related enums, and orchestrator interfaces.
Build Configuration
apps/cli/tsconfig.json
Updates TypeScript base config from @sindresorhus/tsconfig to @superset/typescript/react-library.json; adjusts compiler options (removes skipLibCheck, adds noEmit: false and allowImportingTsExtensions: false); normalizes include array.
Package Metadata
apps/cli/package.json
Adds trailing newline for formatting consistency.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • apps/cli/src/types/index.ts: Verify that all type re-exports are correctly mapped to their new module locations and that no public API surface was inadvertently altered
  • apps/cli/src/types/process.ts: Review the ProcessOrchestrator interface method signatures and ensure async/sync patterns align with codebase conventions
  • apps/cli/src/types/workspace.ts: Confirm WorkspaceOrchestrator method signatures and note the placeholder comment about cloud-specific parameters
  • apps/cli/tsconfig.json: Validate that the new base config and compiler option changes align with project standards and don't break downstream builds

Possibly related PRs

  • cli types #96: Directly overlaps with CLI type definition refactoring and re-exports of Environment/Process/Agent/Terminal types across dedicated modules
  • add ink #95: Modifies apps/cli/package.json and establishes related CLI file infrastructure

Poem

🐰 Types organized with care so fine,
Environment, Workspace, Process align,
Orchestrators dance in modules neat,
Re-exports make the API complete! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cli-types-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed65cee and 7f74f12.

📒 Files selected for processing (6)
  • apps/cli/package.json (1 hunks)
  • apps/cli/src/types/environment.ts (1 hunks)
  • apps/cli/src/types/index.ts (1 hunks)
  • apps/cli/src/types/process.ts (1 hunks)
  • apps/cli/src/types/workspace.ts (1 hunks)
  • apps/cli/tsconfig.json (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite changed the title cli types 1 Add more types Nov 18, 2025
@Kitenite Kitenite merged commit 4a7d5b1 into main Nov 18, 2025
0 of 5 checks passed
@Kitenite Kitenite deleted the cli-types-1 branch November 19, 2025 00:33
This was referenced Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant