Skip to content

fix(desktop): add SF fonts for Apple tools symbol rendering#957

Merged
Kitenite merged 1 commit into
superset-sh:mainfrom
onevcat:fix/terminal-sf-symbols-rendering
Jan 26, 2026
Merged

fix(desktop): add SF fonts for Apple tools symbol rendering#957
Kitenite merged 1 commit into
superset-sh:mainfrom
onevcat:fix/terminal-sf-symbols-rendering

Conversation

@onevcat
Copy link
Copy Markdown
Contributor

@onevcat onevcat commented Jan 26, 2026

Summary

Apple developer tools (swift test, xcodebuild) output symbols from SF Symbols font using Unicode private use area characters. Without SF fonts in the terminal font fallback chain, these characters render as placeholder boxes.

This PR adds SF Mono and SF Pro to the end of the terminal font family list to properly render symbols from Apple tools output while preserving the default font.

Screenshots

Before (without fix)

SCR-20260126-plcr

After (with fix)

SCR-20260126-pkxj

Test Plan

  1. Open Superset terminal
  2. Run swift test in a Swift package directory
  3. Verify that test result symbols (checkmarks/crosses) render correctly instead of showing placeholder boxes

Summary by CodeRabbit

  • New Features
    • Terminal font selection expanded to include SF Mono and SF Pro font options, providing enhanced customization capabilities and improved cross-system font compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

Apple developer tools (swift test, xcodebuild) output symbols from SF Symbols
font using Unicode private use area characters. Without SF fonts in the
fallback chain, these characters render as placeholder boxes.

Add SF Mono and SF Pro to the end of terminal font family list to properly
render symbols from Apple tools output while preserving the default font.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Added two SF font options ("SF Mono" and "SF Pro") to the terminal font family configuration list in the Terminal config file, with supporting descriptive comment. No functional or behavioral changes to the terminal system.

Changes

Cohort / File(s) Summary
Terminal Font Configuration
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/config.ts
Added "SF Mono" and "SF Pro" font entries to TERMINAL_FONT_FAMILY list following "Courier New", with descriptive comment. Affects fontFallback behavior used by TERMINAL_OPTIONS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Fonts dancing in the list so fine,
SF Mono and Pro now align,
After Courier's steady stride,
New typefaces snugly reside,
Terminal's wardrobe, sleek and divine!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding SF fonts to the terminal configuration for proper rendering of Apple tools symbols.
Description check ✅ Passed The description includes the required template sections with clear context, problem explanation, screenshots, and a concrete test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks @onevcat !

@Kitenite Kitenite merged commit 373eed1 into superset-sh:main Jan 26, 2026
5 checks passed
@onevcat onevcat deleted the fix/terminal-sf-symbols-rendering branch January 27, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants