feat(desktop): support F1-F12 as hotkeys without modifiers

[iven]

Description

• Add F1-F12 to ELECTRON_KEY_MAP for hotkey recognition
• Allow function keys (F1-F12) as valid app hotkeys without requiring Cmd/Ctrl modifiers
• Update terminal keyboard handler to let unconfigured F1-F12 pass through to terminal apps
• Rename hasPrimaryModifier to isValidAppHotkey for better semantics

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• Improvements
  • Function keys (F1–F12) can now be assigned as app shortcuts without requiring modifier keys.
  • Enhanced keyboard event recognition for more reliable hotkey detection in the terminal.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes enhance hotkey handling by adding function key support (F1–F12) to the desktop app's keyboard subsystem. The shared hotkeys module now treats function keys as valid app hotkeys without requiring modifiers, renames the validation function to reflect this broader logic, and updates the terminal helper and hotkeys store to use centralized hotkey resolution instead of simple modifier checks.

Changes

Cohort / File(s)	Summary
Hotkeys Core apps/desktop/src/shared/hotkeys.ts	Added F1–F12 function key mappings to ELECTRON_KEY_MAP. Introduced isFunctionKey helper. Refactored hotkeyFromKeyboardEvent to accept function keys without requiring ctrl/meta modifiers. Renamed exported function hasPrimaryModifier → isValidAppHotkey with updated logic to permit function keys as standalone valid hotkeys.
Terminal Keyboard Handling apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts	Replaced simple meta/ctrl key presence check with centralized hotkey resolution via hotkeyFromKeyboardEvent(event, getCurrentPlatform()). Now only processes events recognized as valid hotkeys, delegating key recognition to the shared hotkeys module.
Hotkeys Store Validation apps/desktop/src/renderer/stores/hotkeys/store.ts	Updated hotkey validation in setHotkey and setHotkeysBatch methods from hasPrimaryModifier to isValidAppHotkey, enabling function keys as valid app hotkeys alongside ctrl/meta-modified keys.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• desktop: configurable keyboard shortcuts #538: Directly modifies the same core files (hotkeys.ts, Terminal/helpers.ts, hotkeys store) and shares overlapping hotkey validation and resolution logic changes.
• fix terminal hotkeys doubling #563: Modifies the same Terminal/helpers.ts keyboard handling to refactor app hotkey detection.
• Fix terminal split shortcuts and improve split pane styling #225: Updates both terminal hotkey handling and shared hotkeys logic for improved key event processing and function key support.

Suggested reviewers

• CharlieHelps
• Kitenite

Poem

🐰 Function keys hop into the fray,
F1 through F12 now have their say,
No modifiers needed, hopping free,
Hotkeys resolve most tastefully,
A centralizer's dream, you see! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title accurately summarizes the main change: adding support for function keys F1-F12 as hotkeys without requiring modifiers.
Description check	✅ Passed	The description includes a clear summary of changes and indicates it is a new feature, but lacks related issue links and testing/verification details required by the template.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Kitenite]

@iven Sorry for taking so long, this works!