fix(desktop): ensure notification click switches to correct tab

[kkjcheng]

Summary

• Fix notification click not switching to the correct tab when already on the right workspace
• Add fallback to use event's tabId directly when pane-based resolution fails
• Add debug logging to help diagnose future tab activation issues

Test plan

• Click a notification while on the correct workspace but different tab
• Verify the app switches to the tab that triggered the notification
• Verify pane focus also works correctly

Summary by CodeRabbit

• Bug Fixes
  • Enhanced reliability of tab and pane focus operations by implementing fallback mechanisms to handle missing or unresolved identifiers, ensuring graceful behavior in edge cases where expected data may not be available.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This change hardens the FOCUS_TAB event flow in a tab listener by introducing fallback mechanisms for resolving tabId and paneId, ensuring the handler gracefully degrades when explicit IDs are unavailable by falling back to event data.

Changes

Cohort / File(s)	Summary
Tab focus event resilience apps/desktop/src/renderer/stores/tabs/useAgentHookListener.ts	Added fallback logic to resolve tabId and paneId from event data when target IDs are missing; refactored FOCUS_TAB handler to check for resolved pane existence before calling setFocusedPane and use fallback tabId throughout the flow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(desktop): fix notification indicator not showing on hook events #456: Modifies the same file to harden event-handling logic by fixing stale-closure issues, complementing this PR's fallback resilience approach.
• fix(desktop): fix notification click not opening workspace/tab #354: Also improves focus-tab resilience in useAgentHookListener.ts but uses a resolveNotificationTarget refactor versus this PR's direct fallback-to-event.data pattern.

Suggested reviewers

• Kitenite

Poem

🐰 A rabbit hops through tab events with care,
When IDs go missing, fallbacks are there!
From target to data, a graceful retreat,
Making focus resilience perfectly neat. 🎯✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description covers the problem, solution approach, and test plan, but deviates from the repository template by using a custom structure instead of the required sections like Type of Change, Testing, and Related Issues.	Restructure the description to follow the template: add Type of Change section, expand Testing section with detailed steps, and include Related Issues section with any GitHub issue links.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main fix: ensuring notification clicks switch to the correct tab, which is the primary objective of this changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Kitenite]

Thanks for the fix @kkjcheng !