Skip to content

fix(desktop): remove "View PR on GitHub" tooltip from ChangesHeader#924

Merged
Kitenite merged 1 commit into
superset-sh:mainfrom
chasemcdo:remove-github-pr-tooltip
Jan 25, 2026
Merged

fix(desktop): remove "View PR on GitHub" tooltip from ChangesHeader#924
Kitenite merged 1 commit into
superset-sh:mainfrom
chasemcdo:remove-github-pr-tooltip

Conversation

@chasemcdo
Copy link
Copy Markdown
Contributor

@chasemcdo chasemcdo commented Jan 23, 2026

Summary

  • Remove the "View PR on GitHub" tooltip from the PR status link in the ChangesHeader component
  • The tooltip was overlapping with nearby buttons, making them difficult to click
  • The PR icon and number are already intuitive, so the tooltip didn't add significant value

Test plan

  • Open a workspace with an associated PR
  • Verify the PR number/icon link still opens GitHub when clicked
  • Verify no tooltip appears on hover
  • Verify nearby buttons (stash, view mode, refresh) are easier to click

Resolves #922

Summary by CodeRabbit

  • Style
    • Removed tooltip from PR status link in the Changes view.

✏️ Tip: You can customize this high-level summary in your review settings.

The tooltip was overlapping with nearby buttons, making them difficult
to click. Since the PR icon and number are already intuitive, the
tooltip didn't add significant value.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

This PR removes a Tooltip wrapper around the PR status link in the ChangesHeader component. The link now returns a plain anchor element with the same href, target, rel, and class names, while loading and null-PR states remain unchanged.

Changes

Cohort / File(s) Summary
PR Status Link Unwrapping
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/ChangesView/components/ChangesHeader/ChangesHeader.tsx
Removed Tooltip wrapper around PR status link; link now renders as plain anchor element with preserved attributes (href, target, rel, class names). Loading and null states unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A tooltip takes its final bow,
The PR link stands bare now,
No wrapper, no fluff in sight,
Just clean, honest markup—right!
Simplicity wins the day, meow~

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a tooltip from the PR status link in ChangesHeader.
Description check ✅ Passed The description provides a clear summary, test plan, and issue reference, though it deviates from the template structure with a non-standard format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit eeb2b51 into superset-sh:main Jan 25, 2026
1 check passed
@Kitenite
Copy link
Copy Markdown
Collaborator

Works for me. Thanks @chasemcdo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] github pr view tooltip overlaps button

2 participants