feat(desktop): implement cloud workspace type with UI and creation flow#918
Closed
Kitenite wants to merge 1 commit into
Closed
feat(desktop): implement cloud workspace type with UI and creation flow#918Kitenite wants to merge 1 commit into
Kitenite wants to merge 1 commit into
Conversation
- Add "cloud" to WorkspaceType enum in local-db schema - Add createCloudWorkspace tRPC procedure for creating cloud workspaces - Update NewWorkspaceModal Cloud tab with creation form - Add cloud badge indicator in TopBar when viewing cloud workspace - Update workspace path resolution to handle cloud type (uses main repo path) - Update tooltips and delete dialog to handle cloud workspaces
Contributor
📝 WalkthroughWalkthroughThis PR introduces cloud workspace support by adding a Changes
Sequence DiagramsequenceDiagram
participant User as User / UI
participant Modal as NewWorkspaceModal
participant TRPC as createCloudWorkspace<br/>(Router)
participant DB as Database
participant Tracking as Event Tracking
User->>Modal: Click "Create Cloud Workspace" with name
Modal->>TRPC: Mutate with projectId & name
TRPC->>DB: Query project existence
DB-->>TRPC: Project found
TRPC->>DB: Query max tabOrder for project
DB-->>TRPC: maxTabOrder result
TRPC->>DB: Insert workspace (type=cloud, branch=cloud)
DB-->>TRPC: Workspace created
TRPC->>DB: Update last active workspace
TRPC->>DB: Activate project
TRPC->>Tracking: Track workspace_created event
TRPC-->>Modal: Return { workspace, projectId }
Modal->>Modal: Invalidate workspace queries
Modal->>Modal: Close modal & show success toast
Modal-->>User: Display new cloud workspace
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Collaborator
Author
|
Closing — stale and conflicting, will restart fresh if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
WorkspaceTypeenum inpackages/local-dbcreateCloudWorkspacetRPC procedureTest plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.