feat(desktop): add integrations settings, merge members into organization#904
Merged
feat(desktop): add integrations settings, merge members into organization#904
Conversation
…jects by default - Merge members settings section into organization settings page - Remove standalone /settings/members route - Update navigation links to point to /settings/organization - Collapse projects in sidebar by default - Rename MEMBERS_* setting IDs to ORGANIZATION_MEMBERS_*
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR replaces the Members settings surface with an Integrations section, adds an IntegrationsSettings UI (with TRPC data fetching and connection actions), re-scope member-related setting IDs to organization-scoped IDs, updates routing/type unions, and enhances OrganizationSettings with a members table and related UI. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User (UI)
participant C as IntegrationsSettings (Client)
participant T as TRPC (Client API)
participant B as Backend/API
participant W as Browser (window.open)
U->>C: opens Integrations settings page
C->>T: request integrations + github installation (orgId)
T->>B: fetch integrations & installation status
B-->>T: integrations list + install status
T-->>C: return data
C-->U: render integration cards (Connected/Not Connected)
U->>C: clicks Connect/Manage
C->>W: open external URL (NEXT_PUBLIC_WEB_URL + route)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
New Features
Changes
✏️ Tip: You can customize this high-level summary in your review settings.