Skip to content

fix(desktop): always show close all ports button in sidebar#896

Merged
Kitenite merged 1 commit into
mainfrom
close-all-port-button-always-show
Jan 22, 2026
Merged

fix(desktop): always show close all ports button in sidebar#896
Kitenite merged 1 commit into
mainfrom
close-all-port-button-always-show

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 22, 2026

Summary

  • Makes the "close all ports" button always visible in the workspace sidebar ports list
  • Removes hover-only visibility (opacity-0 group-hover:opacity-100) so users can see and access the button immediately

Test plan

  • Open a workspace with active ports
  • Verify the close all ports (X) button is visible without hovering
  • Verify clicking the button still closes all ports for that workspace

Summary by CodeRabbit

  • Style
    • Close button in workspace port group is now permanently visible instead of appearing only on hover, improving accessibility and discoverability.

✏️ Tip: You can customize this high-level summary in your review settings.

Remove hover-only visibility so the button is always accessible.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

A close button in the WorkspacePortGroup component was modified to display persistently instead of revealing on hover, with its className updated to remove opacity-based transitions.

Changes

Cohort / File(s) Summary
Close Button Visibility
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/PortsList/components/WorkspacePortGroup/WorkspacePortGroup.tsx
Removed opacity-based reveal behavior (opacity-0 and group-hover:opacity-100 with transition-opacity). Button now uses static utility classes (ml-auto p-0.5 rounded hover:bg-muted/50 text-muted-foreground hover:text-primary), making it always visible.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 No more hide-and-seek, dear button dear!
Always present, crystal clear,
No hover needed to make you show,
You're visible now, ready to go!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making the close all ports button always visible in the sidebar instead of hidden until hover.
Description check ✅ Passed The description covers the key aspects of the change with clear motivation and test steps, though it doesn't strictly follow the repository template structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 535bcc7 into main Jan 22, 2026
5 checks passed
@Kitenite Kitenite deleted the close-all-port-button-always-show branch January 22, 2026 08:07
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant