Skip to content

fix(desktop): remove debouncing from branch name input#879

Merged
saddlepaddle merged 1 commit intomainfrom
no-debounce-branch-naming
Jan 21, 2026
Merged

fix(desktop): remove debouncing from branch name input#879
saddlepaddle merged 1 commit intomainfrom
no-debounce-branch-naming

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Jan 21, 2026

Summary

  • Remove 150ms debounce on title input in NewWorkspaceModal that was causing branch names to be truncated when typing quickly
  • Simplify state management by removing the separate localTitle state variable
  • The debounce was unnecessary since generateBranchFromTitle is a simple string transformation

Test plan

  • Open workspace modal
  • Type a feature name quickly
  • Verify branch name updates immediately without truncation
  • Lint, typecheck, tests all pass

Summary by CodeRabbit

  • Bug Fixes
    • Improved workspace title input responsiveness in the new workspace creation modal—the title field now updates instantly as you type, eliminating input lag.

✏️ Tip: You can customize this high-level summary in your review settings.

Remove 150ms debounce on title input that was causing branch names to be
truncated when typing quickly. The debounce was unnecessary since
generateBranchFromTitle is a simple string transformation.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

The NewWorkspaceModal component is simplified by removing debounce logic and eliminating the separate local state variable localTitle. All title input and references now use the primary title state directly, with immediate updates via setTitle() instead of delayed debounced updates.

Changes

Cohort / File(s) Summary
Debounce removal and state simplification
apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx
Removed debounce import and related utilities; eliminated localTitle state variable and handleTitleChange function; replaced all localTitle references with title state; converted input onChange handler to direct setTitle() setter call

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through code so spry,
No bounce needed, state flows dry,
One title state, direct and clean,
The simplest flow we've ever seen! 🌕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references the main change: removing debouncing from the branch name input in the NewWorkspaceModal component.
Description check ✅ Passed The description includes a clear summary of changes, test plan results, and context for the modification. However, it does not follow the provided template structure with sections like Type of Change, Related Issues, or formal Testing section.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saddlepaddle saddlepaddle merged commit d6aa780 into main Jan 21, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant