feat(desktop): drag-and-drop for panes between tabs#859
Merged
Conversation
- Tabs show subtle bg-primary/5 highlight when dragging over - NewTabDropZone shows left indicator bar without layout shift
Contributor
📝 WalkthroughWalkthroughAdds pane drag-and-drop across tabs: introduces a drag-pane Zustand store, a reusable NewTabDropZone, drop handling in GroupItem/GroupStrip, drag wiring in BasePaneWindow, and guards in tabs store and move-pane action to avoid unintended removals or duplicates. Changes
Sequence DiagramsequenceDiagram
participant User
participant BasePaneWindow
participant DragPaneStore
participant GroupItem
participant GroupStrip
participant TabsStore
User->>BasePaneWindow: drag start (onDragStart)
BasePaneWindow->>DragPaneStore: setDragging(paneId, sourceTabId)
DragPaneStore->>DragPaneStore: store draggingPaneId, draggingSourceTabId
User->>GroupItem: hover / enter
GroupItem->>DragPaneStore: read draggingPaneId & draggingSourceTabId
GroupItem->>GroupItem: canDrop? (not same, not duplicate, not last-in-tab)
Note over GroupItem: show highlight if droppable
User->>GroupItem: drop
alt canDrop true
GroupItem->>GroupStrip: onPaneDrop(paneId)
GroupStrip->>TabsStore: movePaneToTab(paneId, targetTabId) / movePaneToNewTab(paneId)
TabsStore->>TabsStore: check duplicate, update layouts, preserve panes that moved away
end
User->>BasePaneWindow: drag end (onDragEnd)
BasePaneWindow->>DragPaneStore: clearDragging()
DragPaneStore->>DragPaneStore: reset dragging state
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Return { handled: true } from drop handlers to signal that the drop
was processed, preventing mosaic from also trying to handle the drop.
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Kitenite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drag-pane-storeto track which pane is being dragged (since MosaicDragItem only has mosaicId)Test plan
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.