fix(desktop): revert migration 11 to simple ADD COLUMN#824
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR applies routine maintenance updates: a version increment for the desktop application package, and metadata adjustments to database migration snapshots and journal timestamps. No functional logic or control flow is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
cbd5b7e to
0b4d898
Compare
Merged
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous fix (#822) used
DROP COLUMNwhich fails if the column doesn't exist (SQLite doesn't supportDROP COLUMN IF EXISTS).Solution
Revert to simple
ALTER TABLE settings ADD terminal_persistence integer;The existing error handler in
apps/desktop/src/main/lib/local-db/index.ts:98-107already catches "duplicate column name" errors and treats them as idempotent, so this handles both:Migration Change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.