Skip to content

feat (desktop): instant scrolldown#814

Closed
AviPeltz wants to merge 2 commits into
mainfrom
instant-scroll-down
Closed

feat (desktop): instant scrolldown#814
AviPeltz wants to merge 2 commits into
mainfrom
instant-scroll-down

Conversation

@AviPeltz
Copy link
Copy Markdown
Collaborator

@AviPeltz AviPeltz commented Jan 18, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Refactor
    • Terminal scroll-to-bottom now jumps instantly rather than animating smoothly.
    • Global page scrolling behavior changed from smooth animation to automatic (no smooth scrolling).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

Renames the terminal scroll utility from smoothScrollToBottom to scrollToBottom, changes its scrolling behavior from "smooth" to "instant", updates call sites/imports, and disables global smooth scrolling in CSS (scroll-behavior: auto).

Changes

Cohort / File(s) Summary
Global CSS
apps/desktop/src/renderer/globals.css
scroll-behavior changed from smooth to auto for html, body.
Terminal scroll utility
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/utils.ts
Function renamed smoothScrollToBottomscrollToBottom; internal scrollTo call now uses behavior: "instant".
Terminal usage updates
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/ScrollToBottomButton/ScrollToBottomButton.tsx
Imports and call sites updated to use scrollToBottom instead of smoothScrollToBottom.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I hopped to the terminal, quick as a wink,
No smooth slow glide — just instant blink.
Pages snap down without a drag or fray,
The rabbit cheers this brisk new way! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The pull request description is entirely empty template placeholders with no actual content filled in across any section. Fill in the Description section explaining what was changed and why (refactoring scroll behavior from smooth to instant), link any related issues, confirm the Refactor type is selected, document testing steps, and add context about the scrolling behavior changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat (desktop): instant scrolldown' directly reflects the main change: replacing smooth scrolling behavior with instant scrolling in the desktop terminal component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

overflow: hidden; /* prevent scroll-lock adjustments from collapsing layout */
user-select: none;
scroll-behavior: smooth;
scroll-behavior: auto;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this

@Kitenite Kitenite closed this Jan 19, 2026
@Kitenite Kitenite deleted the instant-scroll-down branch January 19, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants