fix(desktop): include friendly-words module in packaged app#799
fix(desktop): include friendly-words module in packaged app#799
Conversation
The friendly-words module was imported via CommonJS require syntax but wasn't being bundled by Vite, causing a runtime error in the packaged app. Add it to electron-builder files config.
📝 WalkthroughWalkthroughThis change adds a packaging configuration rule to the Electron Builder that ensures the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
The friendly-words module was imported via CommonJS require syntax but wasn't being bundled by Vite, causing a runtime error in the packaged app. Add it to electron-builder files config.
Summary
Cannot find module 'friendly-words'in packaged desktop appgit.tsbut Vite wasn't bundling itfriendly-wordsto electron-builder files config so it gets included in app.asarTest plan
bun run buildfriendly-wordsis included in app.asarSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.