Skip to content

fix(desktop): include friendly-words module in packaged app#799

Merged
Kitenite merged 1 commit intomainfrom
realistic-guanaco-ec3da3
Jan 18, 2026
Merged

fix(desktop): include friendly-words module in packaged app#799
Kitenite merged 1 commit intomainfrom
realistic-guanaco-ec3da3

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 18, 2026

Summary

  • Fix runtime error Cannot find module 'friendly-words' in packaged desktop app
  • The module is imported via CommonJS require syntax in git.ts but Vite wasn't bundling it
  • Added friendly-words to electron-builder files config so it gets included in app.asar

Test plan

  • Build desktop app with bun run build
  • Verified friendly-words is included in app.asar
  • Test packaged app launches without module error

Summary by CodeRabbit

  • Chores
    • Updated build configuration to ensure proper inclusion and availability of the friendly-words dependency in the packaged application.

✏️ Tip: You can customize this high-level summary in your review settings.

The friendly-words module was imported via CommonJS require syntax
but wasn't being bundled by Vite, causing a runtime error in the
packaged app. Add it to electron-builder files config.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

This change adds a packaging configuration rule to the Electron Builder that ensures the friendly-words module is copied into the built application. The modification mirrors existing patterns for external dependencies, guaranteeing the module is available at runtime outside the asar archive.

Changes

Cohort / File(s) Summary
Electron Builder Configuration
apps/desktop/electron-builder.ts
Added a copy rule for the friendly-words node_modules directory to ensure it's included in the built Electron app alongside other external dependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A module to bundle, so friendly and true,
In the build configuration, I'll pack it for you,
No asar can stop it from reaching runtime,
With copy rules ready, the packaging's sublime! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: including the friendly-words module in the packaged app, which directly addresses the core objective of fixing the module packaging issue.
Description check ✅ Passed The description covers the core sections with clear problem statement and testing verification, but lacks formal adherence to the template structure with missing or incompletely filled required sections like Type of Change and Related Issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 6d994b1 into main Jan 18, 2026
5 checks passed
@Kitenite Kitenite deleted the realistic-guanaco-ec3da3 branch January 18, 2026 18:09
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

saddlepaddle pushed a commit that referenced this pull request Jan 18, 2026
The friendly-words module was imported via CommonJS require syntax
but wasn't being bundled by Vite, causing a runtime error in the
packaged app. Add it to electron-builder files config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant