fix(desktop): use consistent env for persistent terminal sessions

[Kitenite]

Summary

• Fix environment variable handling for persistent terminal sessions in the desktop app
• Ensure consistent env configuration across terminal sessions

Test plan

• Verify terminal sessions receive correct environment variables
• Test persistent terminal sessions maintain env consistency

Summary by CodeRabbit

• Refactor
  • Streamlined environment variable handling for terminal sessions to make startup more reliable.
  • Removed verbose debug logging that exposed shell invocation details and environment paths, reducing console clutter while preserving prior child-process behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Session.spawn now builds the child process environment using buildSafeEnv(...) over the merged host/env map instead of locally filtering process.env; TERM is set to "xterm-256color" and ELECTRON_RUN_AS_NODE behavior for the Electron subprocess is preserved.

Changes

Cohort / File(s)	Summary
PTY Environment Handling apps/desktop/src/main/terminal-host/session.ts	Replaced manual filtering/merging of process.env with buildSafeEnv({ ...process.env, ...env }) to produce processEnv; removed debug spawn logging; still sets TERM="xterm-256color" and preserves ELECTRON_RUN_AS_NODE for the spawned Electron subprocess.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix(desktop): use allowlist for terminal env filtering to prevent secret leakage #582: Introduces/exports buildSafeEnv(...) used here to centralize environment filtering for desktop terminal sessions.
• fix(desktop): restore SUPERSET_ROOT_PATH and related env vars to terminal #311: Also changes PTY spawn environment composition and affects which variables propagate into terminal sessions.

Poem

🐰 I hop through vars both near and far,
Trusting the main to set the spar,
TERM stays bold, the rest made neat,
Less local fuss — a tidy seat! 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(desktop): use consistent env for persistent terminal sessions' clearly and concisely describes the main change: standardizing environment variable handling for persistent terminal sessions in the desktop app.
Description check	✅ Passed	The pull request description covers the main objectives and test plan, but lacks several template sections including 'Related Issues', 'Type of Change', and 'Additional Notes'.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉