fix(desktop): restore OpenInMenuButton to TopBar#749
Conversation
The OpenInMenuButton was accidentally removed in commit aeaed2d ("Router Part 3: Rewrite the workspace handling"). This restores the button using the new workspace query pattern with useParams.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe TopBar component now retrieves the workspaceId from route parameters and fetches workspace data via TRPC. It conditionally renders an OpenInMenuButton component when the workspace contains a worktreePath, passing relevant workspace properties to the button. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
useParamsinstead of the removedgetActivequeryTest plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.