Skip to content

fix(desktop): restore OpenInMenuButton to TopBar#749

Merged
Kitenite merged 1 commit intomainfrom
missing-open-in-buton
Jan 14, 2026
Merged

fix(desktop): restore OpenInMenuButton to TopBar#749
Kitenite merged 1 commit intomainfrom
missing-open-in-buton

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 14, 2026

Summary

Test plan

  • Verify the "Open In" button appears in the TopBar when viewing a workspace
  • Verify clicking the button opens the project in the last used editor
  • Verify the dropdown menu shows all editor options

Summary by CodeRabbit

  • New Features
    • Added a new "Open In" menu button to the TopBar that appears when workspace configuration is available, enabling quick access to workspace-specific actions with branch information.

✏️ Tip: You can customize this high-level summary in your review settings.

The OpenInMenuButton was accidentally removed in commit aeaed2d
("Router Part 3: Rewrite the workspace handling"). This restores
the button using the new workspace query pattern with useParams.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The TopBar component now retrieves the workspaceId from route parameters and fetches workspace data via TRPC. It conditionally renders an OpenInMenuButton component when the workspace contains a worktreePath, passing relevant workspace properties to the button.

Changes

Cohort / File(s) Summary
TopBar Workspace Integration
apps/desktop/src/renderer/screens/main/components/TopBar/index.tsx
Added useParams hook to extract workspaceId from route; implemented TRPC query to fetch workspace data with conditional gating; conditionally render OpenInMenuButton component with worktreePath and branch props when workspace data is available

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A workspace now whispers its secrets so bright,
The TopBar listens with TRPC's delight,
A button appears when the path comes alive,
Small hops of logic help features survive! ✨

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between caa3f54 and ad0a9b8.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/screens/main/components/TopBar/index.tsx

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 66370fa into main Jan 14, 2026
4 of 5 checks passed
@Kitenite Kitenite deleted the missing-open-in-buton branch January 14, 2026 07:52
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant