Router refactor 2: Settings page cleanup by saddlepaddle · Pull Request #732 · superset-sh/superset

saddlepaddle · 2026-01-13T17:45:39Z

maybe done
maybe done

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

New Features
- Redesigned Settings experience with dedicated pages and sidebar navigation instead of modal dialogs
- Account Settings page with user profile and sign-out functionality
- Appearance Settings page with theme selection and markdown style options
- Behavior Settings page for app configuration preferences
- Enhanced Keyboard Shortcuts management with import/export capabilities
- Terminal Presets management page for creating and organizing presets
- Improved workspace data enrichment with project and worktree details
Navigation Updates
- Settings accessed via URL routes (e.g., /settings/account) rather than modal system

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-13T17:45:53Z

📝 Walkthrough

Walkthrough

This PR migrates the desktop app's settings architecture from a modal state-based system to a file-based routing approach using TanStack Router. It removes legacy settings state management, creates new route-based settings pages under /_authenticated/settings/, and enriches workspace TRPC queries with project and worktree metadata including baseBranch detection and persistence.

Changes

Cohort / File(s)	Summary
Workspace TRPC Enrichment `apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts`	Converts synchronous resolver to async; adds fetching of related project and worktree data; implements baseBranch detection and persistence with multiple branch handling; returns enriched workspace payload with project/worktree metadata.
Settings Routes Structure `apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx`, `page.tsx`	New layout file establishes settings route structure; fetches platform via TRPC for Mac-specific spacing; renders sidebar and content outlet.
Account Settings Route `apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx`	New file-based page with full Account Settings UI; fetches user data via TRPC; implements sign-out mutation with success toast and loading skeletons.
Appearance Settings Route `apps/desktop/src/renderer/routes/_authenticated/settings/appearance/page.tsx`, `components/ThemeCard/index.ts`	New appearance settings page with theme gallery grid and markdown style selector; adds ThemeCard component export.
Behavior Settings Route `apps/desktop/src/renderer/routes/_authenticated/settings/behavior/page.tsx`	New behavior settings page with toggle for confirm-on-quit and dropdown for terminal file links; implements optimistic updates and error rollback via TRPC.
Keyboard Shortcuts Route `apps/desktop/src/renderer/routes/_authenticated/settings/keyboard/page.tsx`	Comprehensive keyboard shortcuts management UI with search, recording, conflict detection, import/export; includes confirmation dialogs and terminal/OS reserved key checks.
Presets Settings Route `apps/desktop/src/renderer/routes/_authenticated/settings/presets/page.tsx`, `components/PresetRow/PresetRow.tsx`	New presets management page with template quick-add, inline editing, command editor support; manages local vs. server state sync.
Project/Workspace/Team/Ringtones Settings Routes `apps/desktop/src/renderer/routes/_authenticated/settings/project/$projectId/page.tsx`, `workspace/$workspaceId/page.tsx`, `team/page.tsx`, `ringtones/page.tsx`	Multiple new file-based settings pages using route parameters; replaces previous state-based data fetching with route-driven queries.
Settings Sidebar Components `apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/*`	New sidebar navigation structure with GeneralSettings and ProjectsSettings components; uses route matching for active state instead of callback-based updates.
Legacy Settings Components Removed `apps/desktop/src/renderer/screens/main/components/SettingsView/*`	Removal of 10+ files including SettingsView, SettingsSidebar, AccountSettings, AppearanceSettings, BehaviorSettings, KeyboardShortcutsSettings, PresetsSettings, ProjectSettings, TeamSettings, WorkspaceSettings and index files.
App State Store Update `apps/desktop/src/renderer/stores/app-state.ts`	Removes settings-related state (isSettingsTabOpen, settingsSection) and actions (openSettings, closeSettings, etc.); removes corresponding public hooks; adds closeWorkspacesList support.
Navigation Updates Throughout `apps/desktop/src/renderer/screens/main/components/SettingsButton/SettingsButton.tsx`, `WorkspaceSidebar/ProjectSection/ProjectHeader.tsx`, `WorkspaceSidebar/WorkspaceSidebarHeader/OrganizationDropdown.tsx`, `WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx`, `index.tsx`, `routes/sign-in/page.tsx`	Replaces useOpenSettings with useNavigate; updates navigation calls to route-based paths (e.g., `/settings/account`, `/settings/project/$projectId`).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

Add settings tab to top bar for easier navigation #213: Modifies app-state settings state and actions; directly related to settings state management changes in this PR.
Router Refactor Part One #722: Performs TanStack Router migration and file-based route rework; directly related architectural refactoring.
Create a worktree for each opened branch #113: Modifies workspaces TRPC layer and worktree handling; related to the workspace query enrichment changes.

Suggested reviewers

Kitenite

🐰 Settings routes now hop into place,
Modal state packed away with grace,
Router guides the navigation flow,
Worktree branches richly grow,
Desktop app takes a cleaner bow! 🎭✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is largely incomplete and contains only placeholder text ('maybe done' repeated twice) with unfilled template sections; no concrete changes, testing, or additional context provided.	Replace placeholder text with clear, specific descriptions of the refactoring changes, link any related issues, confirm the type of change (Refactor), describe testing performed, and add any relevant implementation notes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: a router-based refactor to clean up the settings page, moving from a modal/state-based to a file-based routing approach.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 4

🤖 Fix all issues with AI agents

In @apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts:
- Around line 35-74: The duplicated baseBranch detection/persistence logic
should be extracted into a shared helper (e.g., detectAndPersistBaseBranch) and
called from both locations (the current block in query.ts and the getActive
function) to avoid duplication; implement a helper (in ../utils/git.ts or a new
helper file) that accepts the worktree and project objects, returns
worktree.baseBranch if already defined, otherwise runs
hasOriginRemote(project.mainRepoPath), calls detectBaseBranch(worktree.path,
worktree.branch, project.defaultBranch || "main") when remote exists, converts
undefined detection to null, persists the result via
localDb.update(worktrees).set({ baseBranch }).where(eq(worktrees.id,
worktree.id)).run(), and returns the final baseBranch (string | null |
undefined), then replace the duplicated blocks with calls to
detectAndPersistBaseBranch and use its return value.

In @apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx:
- Around line 14-18: The sign-out mutation only handles success; update the
trpc.auth.signOut.useMutation call (signOutMutation) to include an onError
handler that surfaces failures (e.g., toast.error with the error message or a
generic "Sign out failed") and optionally logs the error, and ensure the signOut
wrapper (signOut function) still calls signOutMutation.mutate() so failures
trigger the new onError path; reference trpc.auth.signOut.useMutation,
signOutMutation, and signOut when applying the change.

In
@apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/ProjectsSettings/ProjectsSettings.tsx:
- Around line 14-19: The effect watching groups is re-running on every query
refetch because groups is a new array reference; change it to only perform the
initial expansion once by adding a ref flag (e.g., initialExpansionDoneRef)
checked inside the same useEffect so that when groups.length > 0 you call
setExpandedProjects(new Set(groups.map(g => g.project.id))) only if the ref is
false, then set the ref to true; keep the dependency on groups but guard with
the ref to prevent resetting expandedProjects on subsequent refetches.

In
@apps/desktop/src/renderer/routes/_authenticated/settings/project/$projectId/page.tsx:
- Around line 13-22: The component ProjectSettingsPage currently only
destructures data and isLoading from trpc.projects.get.useQuery (and similarly
for trpc.config.getConfigFilePath.useQuery) which swallows query errors and
causes "Project not found" to show on failures; update both hook usages to also
destructure error (e.g., { data: project, isLoading, error }) and handle error
cases explicitly by rendering a clear error UI/message (using error.message) or
returning early, and avoid treating undefined project as "not found" when an
error exists; also optionally log the error for debugging.

🧹 Nitpick comments (15)

apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/page.tsx (3)
25-151: Consider extracting RingtoneCard to a separate file.

Per coding guidelines, each file should contain only one component. RingtoneCard could be moved to a separate file like ringtone-card.tsx in a shared components directory or a local _components folder.

193-194: Console logging should follow the prefixed context pattern.

The guideline specifies using [domain/operation] message format for console logging.
Suggested change
 			if (playingId === ringtone.id) {
 				try {
 					await trpcClient.ringtone.stop.mutate();
 				} catch (error) {
-					console.error("Failed to stop ringtone:", error);
+					console.error("[ringtone/stop] Failed to stop ringtone:", error);
 				}
 				setPlayingId(null);
 				return;
 			}

 			// Stop any currently playing sound first
 			try {
 				await trpcClient.ringtone.stop.mutate();
 			} catch (error) {
-				console.error("Failed to stop ringtone:", error);
+				console.error("[ringtone/stop] Failed to stop ringtone:", error);
 			}

 			// Play the new sound
 			setPlayingId(ringtone.id);

 			try {
 				await trpcClient.ringtone.preview.mutate({
 					filename: ringtone.filename,
 				});
 			} catch (error) {
-				console.error("Failed to play ringtone:", error);
+				console.error("[ringtone/preview] Failed to play ringtone:", error);
 				setPlayingId(null);
 			}
Also applies to: 203-204, 214-215

219-223: Extract magic numbers to named constants.

The buffer time and default duration values should be named constants for clarity.
Suggested change

Add at module top:
const PREVIEW_BUFFER_SECONDS = 0.5;
const DEFAULT_RINGTONE_DURATION_SECONDS = 5;
const MS_PER_SECOND = 1000;
Then update line 219:
-			const durationMs = ((ringtone.duration ?? 5) + 0.5) * 1000;
+			const durationMs = ((ringtone.duration ?? DEFAULT_RINGTONE_DURATION_SECONDS) + PREVIEW_BUFFER_SECONDS) * MS_PER_SECOND;
apps/desktop/src/renderer/routes/_authenticated/settings/keyboard/page.tsx (3)
42-89: Extract HotkeyRow to its own file.

Per coding guidelines, each file should contain only one component. Consider moving HotkeyRow to a separate file like hotkey-row.tsx in a sibling directory or a shared components location.

Additionally, using the key value as the React key prop (line 78) may cause collisions if the display array ever contains duplicate strings.
Suggested fix for the key prop
 <KbdGroup>
-	{display.map((key) => (
-		<Kbd key={key}>{key}</Kbd>
+	{display.map((key, index) => (
+		<Kbd key={index}>{key}</Kbd>
 	))}
 </KbdGroup>
258-265: Same React key collision risk.

Similar to line 78, using the key value directly as the React key prop could cause issues if the display contains duplicates.
Suggested fix
 <KbdGroup>
-	{showHotkeysDisplay.map((key) => (
-		<Kbd key={key}>{key}</Kbd>
+	{showHotkeysDisplay.map((key, index) => (
+		<Kbd key={index}>{key}</Kbd>
 	))}
 </KbdGroup>
310-310: Extract magic number to a named constant.

The 320px value used in the max-height calculation should be extracted to a named constant at the module top for clarity and maintainability. As per coding guidelines, hardcoded values should be named constants.
Suggested refactor

Add at module top (after line 40):
const HEADER_OFFSET_PX = 320;
Then update line 310:
-<div className="max-h-[calc(100vh-320px)] overflow-y-auto divide-y divide-border">
+<div className={`max-h-[calc(100vh-${HEADER_OFFSET_PX}px)] overflow-y-auto divide-y divide-border`}>
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/PresetRow/PresetRow.tsx (1)

24-56: Consider extracting PresetCell to its own file.

Per coding guidelines, prefer one component per file. While PresetCell is a private helper tightly coupled to PresetRow, extracting it to a separate file (e.g., PresetCell.tsx) would improve adherence to the guideline and make the component easier to test independently.
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx (1)
54-56: Consider extracting the hover delay to a named constant.

The 150 ms timeout value is used in both hover handlers. Per coding guidelines, extract magic numbers to named constants at module top for better readability and maintainability.
Suggested change
+const HOVER_DELAY_MS = 150;
+
 export function GroupStrip() {
   // ...
   const handleDropdownMouseEnter = useCallback(() => {
     if (hoverTimeoutRef.current) {
       clearTimeout(hoverTimeoutRef.current);
     }
     hoverTimeoutRef.current = setTimeout(() => {
       setDropdownOpen(true);
-    }, 150);
+    }, HOVER_DELAY_MS);
   }, []);

   const handleDropdownMouseLeave = useCallback(() => {
     if (hoverTimeoutRef.current) {
       clearTimeout(hoverTimeoutRef.current);
     }
     hoverTimeoutRef.current = setTimeout(() => {
       setDropdownOpen(false);
-    }, 150);
+    }, HOVER_DELAY_MS);
   }, []);
Also applies to: 63-65
apps/desktop/src/renderer/screens/main/index.tsx (1)
104-110: Type assertion may mask invalid route navigation.

The cast as "/settings/account" silences TypeScript but allows any section value through. If event.data.section contains an invalid route name, navigation will fail silently at runtime.

Consider defining a union type for valid sections and validating before navigation:
♻️ Suggested improvement
+const VALID_SETTINGS_SECTIONS = [
+  "account", "team", "appearance", "ringtones", 
+  "keyboard", "presets", "behavior"
+] as const;
+type SettingsSection = (typeof VALID_SETTINGS_SECTIONS)[number];

 trpc.menu.subscribe.useSubscription(undefined, {
   onData: (event) => {
     if (event.type === "open-settings") {
       const section = event.data.section || "account";
-      navigate({ to: `/settings/${section}` as "/settings/account" });
+      if (VALID_SETTINGS_SECTIONS.includes(section as SettingsSection)) {
+        navigate({ to: `/settings/${section}` as `/settings/${SettingsSection}` });
+      } else {
+        navigate({ to: "/settings/account" });
+      }
     }
   },
 });
apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts (1)

76-95: Consider extracting the enriched workspace response builder.

This return structure is duplicated in getActive (Lines 273-292). A shared helper could reduce duplication and ensure consistent response shapes across both procedures.
apps/desktop/src/renderer/routes/_authenticated/settings/presets/page.tsx (2)
91-97: Index-based sync may cause stale data issues.

Using array indices to map between localPresets and serverPresets (e.g., in handleCellBlur, handleCommandsBlur) assumes both arrays maintain identical ordering. If the server reorders presets or concurrent mutations occur, the indices could mismatch, causing updates to the wrong preset.

Consider keying comparisons by preset.id instead of array index:
♻️ Suggested approach
 const handleCellBlur = (rowIndex: number, column: PresetColumnKey) => {
   const preset = localPresets[rowIndex];
-  const serverPreset = serverPresets[rowIndex];
+  const serverPreset = serverPresets.find((p) => p.id === preset?.id);
   if (!preset || !serverPreset) return;
   if (preset[column] === serverPreset[column]) return;
   // ...
 };
Apply the same pattern to handleCommandsBlur.
150-156: Consider validating or auto-focusing new preset name.

Creating a preset with an empty name may lead to confusing UX if the user doesn't immediately rename it. Consider either auto-focusing the name input after creation or generating a default name like "Untitled Preset".
apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx (1)
62-64: Minor: Unnecessary arrow function wrapper.

The onClick={() => signOut()} can be simplified to onClick={signOut} since signOut takes no arguments.
♻️ Suggested simplification
-<Button variant="outline" onClick={() => signOut()}>
+<Button variant="outline" onClick={signOut}>
   Sign Out
 </Button>
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/page.tsx (1)
63-74: Consider deriving SelectItem values from the MarkdownStyle type to prevent drift.

The SelectItem values ("default", "tufte") currently match the MarkdownStyle type definition, but hardcoding them in two places creates maintenance risk. To ensure future changes to the type are reflected in the UI, consider deriving the items from a shared constant.
♻️ Recommended approach
const MARKDOWN_STYLES = ["default", "tufte"] as const;
type MarkdownStyle = (typeof MARKDOWN_STYLES)[number];

// Then in JSX:
{MARKDOWN_STYLES.map((style) => (
  <SelectItem key={style} value={style}>
    {style === "default" ? "Default" : "Tufte"}
  </SelectItem>
))}
apps/desktop/src/renderer/routes/_authenticated/settings/behavior/page.tsx (1)

70-74: Consider deriving SelectItem values from the type definition for maintainability.

The type assertion value as TerminalLinkBehavior is currently safe because the SelectItem values ("external-editor", "file-viewer") match the TERMINAL_LINK_BEHAVIORS constant exactly, and the tRPC endpoint validates input using z.enum(TERMINAL_LINK_BEHAVIORS). However, to prevent accidental drift between the UI options and type definition in the future, extract the SelectItem values directly from the TERMINAL_LINK_BEHAVIORS constant.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b17262c and b64514f.

📒 Files selected for processing (54)

apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts
apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/components/ThemeCard/ThemeCard.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/components/ThemeCard/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/behavior/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/SettingsSidebar.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/GeneralSettings/GeneralSettings.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/GeneralSettings/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/ProjectsSettings/ProjectsSettings.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/ProjectsSettings/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/keyboard/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/CommandsEditor/CommandsEditor.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/CommandsEditor/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/PresetRow/PresetRow.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/PresetRow/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/presets/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/types.ts
apps/desktop/src/renderer/routes/_authenticated/settings/project/$projectId/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/team/components/InviteMemberButton/InviteMemberButton.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/team/components/InviteMemberButton/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/team/components/MemberActions/MemberActions.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/team/components/MemberActions/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/team/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/workspace/$workspaceId/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/workspace/page.tsx
apps/desktop/src/renderer/routes/sign-in/page.tsx
apps/desktop/src/renderer/screens/main/components/SettingsButton/SettingsButton.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/AccountSettings/AccountSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/AccountSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/AppearanceSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/BehaviorSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/KeyboardShortcutsSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/PresetsSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/ProjectSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/RingtonesSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsContent.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsSidebar/ProjectsSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsSidebar/SettingsSidebar.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/components/MemberRow/MemberRow.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/components/MemberRow/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/WorkspaceSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceSidebarHeader/OrganizationDropdown.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx
apps/desktop/src/renderer/screens/main/index.tsx
apps/desktop/src/renderer/stores/app-state.ts

💤 Files with no reviewable changes (20)

apps/desktop/src/renderer/screens/main/components/SettingsView/WorkspaceSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsSidebar/SettingsSidebar.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/AppearanceSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/BehaviorSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/PresetsSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsSidebar/ProjectsSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/AccountSettings/AccountSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/components/MemberRow/MemberRow.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/ProjectSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/KeyboardShortcutsSettings.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/page.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/index.ts
apps/desktop/src/renderer/screens/main/components/SettingsView/index.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/AccountSettings/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/workspace/page.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/RingtonesSettings/index.ts
apps/desktop/src/renderer/routes/sign-in/page.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/SettingsContent.tsx
apps/desktop/src/renderer/screens/main/components/SettingsView/TeamSettings/components/MemberRow/index.ts

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/SettingsSidebar.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/ProjectsSettings/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/components/ThemeCard/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/ProjectsSettings/ProjectsSettings.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/GeneralSettings/index.ts
apps/desktop/src/renderer/routes/_authenticated/settings/project/$projectId/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/components/GeneralSettings/GeneralSettings.tsx
apps/desktop/src/renderer/screens/main/components/SettingsButton/SettingsButton.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/appearance/page.tsx
apps/desktop/src/lib/trpc/routers/workspaces/procedures/query.ts
apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/page.tsx
apps/desktop/src/renderer/screens/main/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/workspace/$workspaceId/page.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceSidebarHeader/OrganizationDropdown.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/behavior/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/keyboard/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/team/page.tsx
apps/desktop/src/renderer/routes/_authenticated/settings/presets/components/PresetRow/PresetRow.tsx
apps/desktop/src/renderer/stores/app-state.ts

**/*.{ts,tsx}