Skip to content

fix(desktop): allow spaces in workspace rename input#699

Merged
Kitenite merged 1 commit intomainfrom
workspace-name-no-space
Jan 10, 2026
Merged

fix(desktop): allow spaces in workspace rename input#699
Kitenite merged 1 commit intomainfrom
workspace-name-no-space

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 9, 2026

Summary

  • Fix workspace rename input not accepting space characters
  • Skip keyboard navigation handling (Enter/Space to activate) when rename mode is active

Test plan

  • Double-click a workspace to enter rename mode
  • Type a name with spaces (e.g., "My Workspace")
  • Verify spaces are typed correctly instead of activating the workspace

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Prevented keydown events from bubbling during workspace item renaming, avoiding unintended actions or shortcuts interfering with the rename flow.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 9, 2026

📝 Walkthrough

Walkthrough

Replaced the previous onKeyDown behavior in WorkspaceListItem to first call event.stopPropagation() and then delegate to rename.handleKeyDown, preventing keydown events from bubbling during rename operations without changing rename logic.

Changes

Cohort / File(s) Summary
WorkspaceListItem keydown update
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
onKeyDown now calls event.stopPropagation() before invoking rename.handleKeyDown, preventing keydown event bubbling during rename mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I paused the keys that tried to stray,
A gentle hop, then paved the way,
Rename uninterrupted, neat and bright,
I guard the typing through the night,
Hooray — small change, big delight!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks the required template structure with sections like 'Type of Change', 'Testing', and other standard sections, making it incomplete compared to the repository template. Restructure the description to match the template: add 'Type of Change' section with checkbox selection, expand 'Testing' with detailed steps, and use 'Related Issues' and 'Description' sections as specified.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main fix: allowing spaces in workspace rename input, which aligns with the primary change shown in the file summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 316d2d2 and fccf21e.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add stopPropagation to the rename input's onKeyDown handler to prevent
keyboard events from bubbling to the parent container. This is consistent
with how onClick and onMouseDown are already handled on the input.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Kitenite Kitenite force-pushed the workspace-name-no-space branch from 316d2d2 to fccf21e Compare January 9, 2026 23:58
@Kitenite Kitenite merged commit 42e7be5 into main Jan 10, 2026
5 checks passed
@Kitenite Kitenite deleted the workspace-name-no-space branch January 10, 2026 00:00
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

saddlepaddle pushed a commit that referenced this pull request Jan 10, 2026
Add stopPropagation to the rename input's onKeyDown handler to prevent
keyboard events from bubbling to the parent container. This is consistent
with how onClick and onMouseDown are already handled on the input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant