fix(desktop): fix electron import error in bounds-validation test

[Kitenite]

Summary

• Fixed bounds-validation.test.ts failing with "Export named 'screen' not found in module electron"
• The issue was caused by static imports being resolved before mock.module could intercept them
• Changed to use mock.module for electron before dynamic import, following the same pattern used in terminal manager tests

Test plan

• Verified all 973 tests pass after the fix
• Confirmed the bounds-validation test suite (31 tests) runs successfully

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests

• Enhanced test setup and coverage for window bounds validation across multiple display configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The test file for bounds-validation is reworked to properly mock Electron's screen API before module import. The setup defers importing the tested module using dynamic imports and establishes mockScreen with display methods, uses mock.module for Electron injection, and introduces a MockType alias for improved type safety in test casts.

Changes

Cohort / File(s)	Summary
Test Infrastructure Refactoring apps/desktop/src/main/lib/window-state/bounds-validation.test.ts	Restructures test setup to mock Electron screen API before module import. Introduces dynamic import deferral, mockScreen object with getPrimaryDisplay/getAllDisplays methods, MockType alias for type casts, and updated mock.module injection pattern. Changes: +52/-20

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(desktop): persist window size and position across app restarts #550: Directly related as both PRs modify bounds-validation test infrastructure and mock patterns for Electron window state handling.

Poem

🐰 Mocks are set before we test,
Deferring imports, doing best,
Screen displays now properly mocked,
Test gates securely locked!
Types precise with MockType's might ✨

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e24f8 and 27bd67a.

⛔ Files ignored due to path filters (1)

• bun.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• apps/desktop/src/main/lib/window-state/bounds-validation.test.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Deployment

🔗 Preview Links

Service	Status	Link
Database (Neon)	✅	View Branch
Electric (Fly.io)	✅	View App
API (Vercel)	✅	Open Preview
Web (Vercel)	✅	Open Preview
Marketing (Vercel)	✅	Open Preview
Admin (Vercel)	✅	Open Preview
Docs (Vercel)	✅	Open Preview

---

Preview updates automatically with new commits