refactor(desktop): remove dropdown from add workspace button in sidebar by Kitenite · Pull Request #639 · superset-sh/superset

Kitenite · 2026-01-07T02:05:31Z

Summary

Simplify the "Add Workspace" button in the sidebar by removing the dropdown menu
Clicking the "+" button now directly opens the New Workspace modal instead of showing a dropdown with "New Workspace" and "Quick Create" options

Summary by CodeRabbit

Refactor
- Simplified workspace creation interface by replacing the dropdown menu with a straightforward button and tooltip
- Removed Quick Create feature; workspace creation now exclusively uses the dedicated modal for a more direct workflow

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Replace the dropdown menu with a simple button that directly opens the New Workspace modal, removing the Quick Create option.

coderabbitai · 2026-01-07T02:05:43Z

📝 Walkthrough

Walkthrough

The PR simplifies workspace creation UI by removing the dropdown-based flow with Quick Create functionality. A single button now triggers the New Workspace modal directly, eliminating associated state management and handlers from ProjectHeader and ProjectSection components.

Changes

Cohort / File(s)	Summary
Workspace Creation UI Simplification `apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx`, `apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectSection.tsx`	Removed dropdown menu UI components, Quick Create flow, and related state props (`onQuickCreate`, `isCreating`, `dropdownOpen`, `onDropdownOpenChange`). Replaced with a tooltip-wrapped button that directly invokes `onNewWorkspace` to open the workspace creation modal. Eliminated `useCreateWorkspace` query hook and dropdown state management.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Add dropdown create modal #391 — Modifies the same workspace-creation flow by removing dropdown/quick-create and replacing it with modal-driven New Workspace action in sidebar/header components.
refactor (desktop): New workspace button #596 — Refactors workspace "New Workspace" UI by adding NewWorkspaceButton and header refactoring to surface a unified New Workspace control.

Suggested reviewers

CharlieHelps

Poem

🐰 Workspace creation, simpler now,
No dropdown clutter, just a bow,
One button opens modal's door,
Clean and swift, we ask no more! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides a summary of changes but lacks the structured template sections (Related Issues, Type of Change, Testing, Screenshots) required by the repository template.	Add missing template sections: mark the Type of Change (Refactor), add Related Issues if applicable, describe testing performed, and include any additional context.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main refactoring change: removing the dropdown from the add workspace button, which aligns with the primary change shown in the file summaries.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx (1)
211-228: Consider adding aria-label for better accessibility.

The simplified button UI is well-implemented with proper event handling. For improved screen reader accessibility, consider adding an aria-label to the button element, as tooltips may not be immediately announced by assistive technologies.
🔎 Suggested accessibility enhancement
 <TooltipTrigger asChild>
 	<button
 		type="button"
+		aria-label="New workspace"
 		onClick={(e) => {
 			e.stopPropagation();
 			onNewWorkspace();
 		}}
 		onContextMenu={(e) => e.stopPropagation()}
 		className="p-1 rounded hover:bg-muted transition-colors shrink-0 ml-1"
 	>
 		<HiMiniPlus className="size-4 text-muted-foreground" />
 	</button>
 </TooltipTrigger>

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce35c5 and d8d9d7a.

📒 Files selected for processing (2)

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectSection.tsx

💤 Files with no reviewable changes (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectSection.tsx

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx

**/*.{ts,tsx}