Remove dead code and add presets support

[Kitenite]

• refactor(desktop): update changes view (refactor(desktop): update changes view #595)
• remove tabs view

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Release Notes

• Refactor
  • Removed terminal tab context menus and preset management dialogs
  • Restructured tab rendering and interaction components

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@Kitenite has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4344950 and 2f6bffc.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/GroupStrip/GroupStrip.tsx

📝 Walkthrough

Walkthrough

This pull request removes the entire TabsView subsystem from the application, including the PresetContextMenu, TabContextMenu, TabItem, TabsCommandDialog, and TabsView components. The deletion eliminates tab management, drag-and-drop reordering, preset handling, tab renaming, and related context menu functionality.

Changes

Cohort / File(s)	Summary
Preset and Tab Context Menus apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/PresetContextMenu/index.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/TabItem/TabContextMenu.tsx	Removed context menu components that provided "Open as New Tab", "Open as Pane", "Rename Tab", and "Close Tab" actions with conditional tooltip wrapping
Tab Item Component apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/TabItem/index.tsx	Deleted entire TabItem component including drag-and-drop handlers, rename state management, focus logic, and tab interaction rendering
Tabs Command Dialog apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/TabsCommandDialog/index.tsx	Removed command dialog UI for creating new terminals, selecting presets, and accessing preset settings
TabsView Container apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx	Deleted primary TabsView component managing tab list rendering, workspace-scoped tab operations, preset integration, drag-and-drop orchestration, and button group actions

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• superset-sh/superset#393: Modifies TabsView and pane-creation code paths for preset and tab handling integration
• superset-sh/superset#302: Updates the same Sidebar TabsView and TabItem preset UI components
• superset-sh/superset#115: Directly modifies TabItem and TabsView component implementations

Poem

🐰 With a hop and a hop, the tabs take their leave,
Context menus vanish like clover in the breeze,
Drag-and-drop gone, rename flows cease,
The sidebar breathes lighter, now finding its peace! 🍀

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title is partially related to the changeset but not the main point. While the PR removes dead code, the title also mentions 'add presets support', which contradicts the actual changes that entirely remove preset-related components.	Update the title to accurately reflect the primary change, such as 'Remove dead code and unused components' or 'Remove TabsView and related components', as the PR removes rather than adds presets support.
Description check	⚠️ Warning	The description is largely incomplete. It contains only minimal information ('remove tabs view') and leaves almost all required template sections unfilled, including a proper description of changes, related issues, type of change selection, testing details, and additional context.	Complete the description by filling in the key sections: provide a clear summary of why these components were removed, link any related issues, select the appropriate type of change (likely 'Refactor'), describe testing performed, and add any relevant context.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉