Skip to content

fix(desktop): remove redundant open project button from workspace modal#573

Merged
Kitenite merged 2 commits into
mainfrom
remove-dedundant-open-project
Jan 1, 2026
Merged

fix(desktop): remove redundant open project button from workspace modal#573
Kitenite merged 2 commits into
mainfrom
remove-dedundant-open-project

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 1, 2026

Summary

  • Remove the "Open" button from the new workspace modal since it duplicates functionality available in the start view
  • Clean up unused imports and handlers (handleOpenNewProject, useOpenNew, useCreateBranchWorkspace)
  • Simplify the project selector layout to full width

Test plan

  • Open the new workspace modal and verify the "Open" button is gone
  • Verify the project selector dropdown is full width
  • Verify creating a new workspace still works correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • UI Improvements
    • Simplified the New Workspace dialog by removing the project-opening path and streamlining project selection to a single picker.
    • Kept core workspace creation flow (mode toggle, branch/base selection) while removing instant-open and main-workspace creation options.
    • Updated New Workspace button label from "Create" to "Workspace".

✏️ Tip: You can customize this high-level summary in your review settings.

The new workspace modal no longer needs the "Open" button since users can open projects from the start view.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 1, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The NewWorkspaceModal UI and logic for opening existing projects and creating a main workspace on the current branch were removed; project selection was simplified to a single Select and styling adjusted. The CreateWorkspaceButton label text was changed.

Changes

Cohort / File(s) Summary
NewWorkspaceModal simplification
apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx
Removed handlers and UI for opening existing projects and creating branch/main workspaces (e.g., handleOpenNewProject, openNew, createBranchWorkspace). Removed Tooltip, TooltipTrigger, TooltipContent, and the inline Open button/icon. Dropped imports/hooks for init/open-worktree flows; preserved createWorkspace flow and core modal controls. Adjusted SelectTrigger styling from flex-1 to w-full.
Button label update
apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/CreateWorkspaceButton.tsx
Changed button text from "Create" to "Workspace" (UI text update only; no handler/control-flow changes).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #461: Modifies the same NewWorkspaceModal and changes Tooltip/new-project handling—directly related to removed tooltip/open-project flow.
  • #531: Touches the open/import project action in NewWorkspaceModal; overlaps with UI/button/icon changes removed here.
  • #265: Introduced the openNew/initGit flow and hooks that are being removed by this change.

Suggested reviewers

  • CharlieHelps

Poem

🐰 A quiet modal, neat and small,
I hopped and nudged to clear the hall.
One select to pick, one button true,
Fewer paths to wander through.
🥕 Hooray—less clutter, more ado!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a redundant open project button from the workspace modal.
Description check ✅ Passed The description covers the main changes, provides a test plan, and includes relevant context, though it lacks explicit sections matching the template structure.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50b18d2 and 29d75a2.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/CreateWorkspaceButton.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 4c103e4 into main Jan 1, 2026
4 of 5 checks passed
@Kitenite Kitenite deleted the remove-dedundant-open-project branch January 1, 2026 19:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant