Skip to content

add danger#55

Merged
Kitenite merged 1 commit intomainfrom
stuff-1
Nov 10, 2025
Merged

add danger#55
Kitenite merged 1 commit intomainfrom
stuff-1

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Nov 10, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Bug Fixes
    • Updated terminal command execution for tasks to improve startup behavior and compatibility. The modification changes the underlying CLI command invocation when initializing task terminals, while fully preserving all existing functionality including workspace and worktree resolution, tab management, status tracking, and error handling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Modified the TaskCard.tsx file to add the --dangerously-skip-permissions flag to the claude command invoked when starting a task's terminal. This changes the CLI command from claude "escapedPrompt" to claude --dangerously-skip-permissions "escapedPrompt".

Changes

Cohort / File(s) Change Summary
CLI Flag Addition
apps/desktop/src/renderer/screens/main/components/PlanView/TaskCard.tsx
Added --dangerously-skip-permissions flag to the claude command invocation when starting a terminal for a task

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #53: Both PRs modify the TaskCard.tsx terminal-start command invocation—PR #53 changed the command argument to an escaped task prompt, and this PR adds the --dangerously-skip-permissions flag to that claude invocation.

Poem

🐰 A flag finds its way, bold and true,
Permissions? Skip them right on through!
The terminal awakens with newfound might,
Where permissions dance out of sight. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch stuff-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d3ca38 and 99a0cca.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/screens/main/components/PlanView/TaskCard.tsx (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit fe59ed3 into main Nov 10, 2025
1 of 5 checks passed
@Kitenite Kitenite deleted the stuff-1 branch November 10, 2025 18:50
@Kitenite Kitenite mentioned this pull request Nov 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant