Skip to content

update electric sql setup script to use valid name only#526

Merged
Kitenite merged 1 commit intomainfrom
rural-amphibian-304de7
Dec 28, 2025
Merged

update electric sql setup script to use valid name only#526
Kitenite merged 1 commit intomainfrom
rural-amphibian-304de7

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Dec 28, 2025

  • update electric sql docker port

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Chores
    • Improved container naming sanitization to ensure proper formatting and system compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 28, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change adds sanitization logic to derive a valid container name suffix from WORKSPACE_NAME by lowercasing, filtering allowed characters, collapsing dashes, and trimming edges, then constructs the ELECTRIC_CONTAINER name using this sanitized suffix truncated to 64 characters.

Changes

Cohort / File(s) Summary
Container name sanitization
\.superset/setup.sh``
Added logic to sanitize WORKSPACE_NAME into CONTAINER_SUFFIX (lowercase, alphanumeric/dash-only, collapsed dashes, trimmed edges), then construct ELECTRIC_CONTAINER as "superset-electric-$CONTAINER_SUFFIX" truncated to 64 characters, replacing previous direct assignment

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰✨ A container name so clean and neat,
Lowercased dashes in perfect repeat,
Sanitized, trimmed, just right for the task,
The Superset electric now wears a new mask!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rural-amphibian-304de7

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c6f71c and 0c67bf2.

📒 Files selected for processing (1)
  • .superset/setup.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 5be2468 into main Dec 28, 2025
5 of 6 checks passed
@Kitenite Kitenite deleted the rural-amphibian-304de7 branch December 28, 2025 15:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 28, 2025

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant