fix(desktop): stop gating v2 workspace on flaky host online status

[saddlepaddle]

Summary

Removes the full-screen "Host is offline" state from the v2 workspace details page.

The screen was gated on `v2Hosts.isOnline` (a DB flag written by the relay) and a `host.info` probe. Both drift from reality:

• `isOnline` can be stuck `true` after a relay crash/redeploy, or stuck `false` if the relay's `setOnline` write blipped
• The probe is enabled only when `isOnline === true`, so a stuck-false flag means we show offline immediately without ever asking the host

End result: users see "Host is offline" on hosts that are actually reachable.

What changes

• `useRemoteHostStatus` no longer returns an `offline` variant; the `enabled` gate on the version probe drops the `isOnline` dependency
• `layout.tsx` drops the offline branch
• `WorkspaceHostOfflineState` component deleted (no other consumers)
• The "incompatible" version-mismatch gate stays — that fires only on a successful probe with a too-old version, so it's not affected by reachability flakiness

Downstream queries (load branches, files, terminals) already surface their own errors when the host is genuinely unreachable. They're the correct place to communicate that, not a pre-emptive layout gate.

Test plan

• Open a v2 workspace whose host has `isOnline=false` in the DB but is actually reachable → workspace renders (previously: offline screen)
• Open a v2 workspace on a genuinely-offline host → workspace shell renders; individual queries surface their own errors
• Open a v2 workspace on a host running an incompatible host-service version → "incompatible" screen still appears
• `bun run lint` + `bun --bun turbo run typecheck --filter=@superset/desktop` pass

---

Summary by cubic

Remove the flaky “Host is offline” gate on the v2 workspace page so the workspace renders by default; only a confirmed version mismatch still blocks with the “incompatible” screen. This prevents false offline screens caused by stale v2Hosts.isOnline or transient probe failures.

• Bug Fixes
  • Dropped offline status from useRemoteHostStatus and removed the isOnline-gated host.info probe.
  • Removed the offline branch from layout and deleted WorkspaceHostOfflineState.
  • Kept the version check: shows “incompatible” only when host.info succeeds and the version is too old.

^{Written for commit c2cc393. Summary will update on new commits.}

Summary by CodeRabbit

• Refactor
  • Removed offline status handling from workspace host monitoring. The system no longer tracks or displays offline states for workspace hosts.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff60f75e-05df-4c6e-be17-b378f53ffe4c

📥 Commits

Reviewing files that changed from the base of the PR and between eafb0c2 and c2cc393.

📒 Files selected for processing (4)

• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/WorkspaceHostOfflineState.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/index.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/layout.tsx

---

📝 Walkthrough

Walkthrough

This PR removes support for the "offline" host status. The RemoteHostStatus type is simplified to only expose skip, loading, incompatible, and ready states. The useRemoteHostStatus hook is refactored to stop checking the host's online field and instead only report incompatibility when the host version doesn't meet the minimum requirement. The WorkspaceHostOfflineState component is deleted entirely, and the layout's offline case handling is removed.

Changes

Offline Status Removal

Layer / File(s)	Summary
Type Contract Update apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts	RemoteHostStatus type removes the "offline" variant; only "skip", "loading", "incompatible", and "ready" states remain.
Hook Implementation Refactor apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts	The hook's useLiveQuery no longer projects isOnline, the host-info query enabling condition changes from requiring hostRow?.isOnline to requiring only workspace and isLocal, and the return logic removes offline branching (no host row, isOnline false, pending/error) in favor of only checking semver incompatibility.
Component Removal apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/WorkspaceHostOfflineState.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/index.ts	WorkspaceHostOfflineState component, its WorkspaceHostOfflineStateProps interface, and the module re-export are deleted.
Layout Integration Cleanup apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/layout.tsx	Removes the import of WorkspaceHostOfflineState and deletes the render branch that handled hostStatus.status === "offline", allowing offline to fall through to workspace initialization.

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 No more offline states to confound,
The host's heart beats steady and sound,
We check only what matters—can it run?
The journey continues, the cleanup is done! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-host-offline-screen

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉

[greptile-apps]

Greptile Summary

This PR removes the full-screen "Host is offline" gate from the v2 workspace layout, replacing flaky isOnline DB-flag and probe-gating logic with optimistic rendering that lets downstream queries surface connectivity errors directly.

• useRemoteHostStatus: drops the offline status variant, removes the isOnline field from the DB query, and enables the version probe unconditionally for remote workspaces; the incompatible return now fires only on infoQuery.isSuccess.
• layout.tsx: removes the offline branch and its import; incompatible and loading guards are unchanged.
• WorkspaceHostOfflineState component and barrel export are deleted with no remaining consumers.

Confidence Score: 4/5

Safe to merge for the offline-flakiness fix; the incompatible-version path now shows a brief flash of workspace content before the gate fires.

The removal of the isOnline gate and the offline screen is clean and well-motivated. The one behavioral regression is that infoQuery.isPending no longer maps to a loading state — the workspace shell mounts optimistically while the version probe is in-flight, and child components begin their own fetches before potentially being torn down by the incompatible screen. For most users this is invisible (compatible host, quick probe), but on a slow relay or an incompatible host it produces a visible flash and wasted requests.

useRemoteHostStatus.ts — the infoQuery.isPending path now returns ready instead of loading, which is the source of the flash-before-incompatible issue.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts	Removes offline status and isOnline DB gate; probe now always fires for remote workspaces. Missing infoQuery.isPending → loading mapping causes the hook to return ready during the version probe, allowing the workspace shell to mount before an incompatible result can be detected.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/layout.tsx	Removes the offline branch and the WorkspaceHostOfflineState import cleanly; remaining incompatible and loading checks are untouched.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/WorkspaceHostOfflineState.tsx	Component deleted — confirmed no other consumers in the diff.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/components/WorkspaceHostOfflineState/index.ts	Barrel re-export deleted alongside the component — clean removal.

Sequence Diagram

sequenceDiagram
    participant L as layout.tsx
    participant H as useRemoteHostStatus
    participant DB as v2Hosts (LiveQuery)
    participant P as host.info probe

    L->>H: call useRemoteHostStatus(workspace)
    H->>DB: query host row (name only, no isOnline)
    H->>P: "fire probe (enabled: workspace != null && !isLocal)"

    note over H: While probe is pending…
    H-->>L: "{ status: "ready" }"
    L-->>L: renders WorkspaceProvider + Outlet (child queries fire)

    P-->>H: probe resolves
    alt version OK
        H-->>L: "{ status: "ready" }"
        note over L: No change — workspace stays rendered
    else version too old
        H-->>L: "{ status: "incompatible", hostName, hostVersion, minVersion }"
        L-->>L: tears down workspace, shows incompatible screen
    end

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts:71-83
**Workspace renders before version check completes**

Previously, `infoQuery.isPending` returned `{ status: "loading" }`, which kept the layout in the blank-div state until the probe settled. That guard is gone. Now, while the version probe is in-flight, `infoQuery.isSuccess` is false so the hook skips the `incompatible` branch and falls straight through to `return { status: "ready" }`. The layout immediately mounts `<WorkspaceProvider><Outlet /></WorkspaceProvider>`, child components (terminals, branch list, file tree) start firing their own queries, and then — after one network round-trip — the layout tears all of that down and shows the incompatible screen. The PR description says the incompatible gate "stays", but it now fires with a visible flash of workspace content preceding it.

_{Reviews (1): Last reviewed commit: "fix(desktop): stop gating v2 workspace o..." | Re-trigger Greptile}

[greptile-apps]

Workspace renders before version check completes

Previously, infoQuery.isPending returned { status: "loading" }, which kept the layout in the blank-div state until the probe settled. That guard is gone. Now, while the version probe is in-flight, infoQuery.isSuccess is false so the hook skips the incompatible branch and falls straight through to return { status: "ready" }. The layout immediately mounts <WorkspaceProvider><Outlet /></WorkspaceProvider>, child components (terminals, branch list, file tree) start firing their own queries, and then — after one network round-trip — the layout tears all of that down and shows the incompatible screen. The PR description says the incompatible gate "stays", but it now fires with a visible flash of workspace content preceding it.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/hooks/useRemoteHostStatus/useRemoteHostStatus.ts
Line: 71-83

Comment:
**Workspace renders before version check completes**

Previously, `infoQuery.isPending` returned `{ status: "loading" }`, which kept the layout in the blank-div state until the probe settled. That guard is gone. Now, while the version probe is in-flight, `infoQuery.isSuccess` is false so the hook skips the `incompatible` branch and falls straight through to `return { status: "ready" }`. The layout immediately mounts `<WorkspaceProvider><Outlet /></WorkspaceProvider>`, child components (terminals, branch list, file tree) start firing their own queries, and then — after one network round-trip — the layout tears all of that down and shows the incompatible screen. The PR description says the incompatible gate "stays", but it now fires with a visible flash of workspace content preceding it.

How can I resolve this? If you propose a fix, please make it concise.