Skip to content

fix(desktop): even row height between Mine and Team in automations#4402

Merged
saddlepaddle merged 1 commit into
mainfrom
revert-kiet-automations
May 11, 2026
Merged

fix(desktop): even row height between Mine and Team in automations#4402
saddlepaddle merged 1 commit into
mainfrom
revert-kiet-automations

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented May 11, 2026

Summary

  • Pin automation list rows to h-10 so Mine and Team scopes render identically (Owner column and pause badge no longer drift row height).

Test plan

  • Open Automations, toggle Mine ↔ Team — rows are visually the same height.
  • Confirm a paused automation (with the "paused" badge) keeps the row at the same height.

Summary by cubic

Set a fixed h-10 height for automation list rows so Mine and Team views render identically. Prevents the Owner column and paused badge from changing row height.

Written for commit 801db13. Summary will update on new commits.

Summary by CodeRabbit

  • Style
    • Refined automation table row styling with fixed height sizing for improved visual consistency and better layout alignment.

Review Change Stack

Pin the row to h-10 so the Owner column (Team-only) and pause badge
can't change row height across scopes.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d33f7001-68cf-4848-a4a0-e35e9d2a314e

📥 Commits

Reviewing files that changed from the base of the PR and between a1b4dec and 801db13.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/page.tsx

📝 Walkthrough

Walkthrough

The automation dashboard table row container styling is updated to use fixed height sizing instead of padding-based height. The row now explicitly declares a group/row class to enable row-scoped styling semantics without changing rendering or data logic.

Changes

Automation Table Row Styling

Layer / File(s) Summary
Automation Table Row Styling
apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/page.tsx
Automation row container className updated from py-2.5 vertical padding to h-10 fixed height with group/row class for row-scoped styling.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A row stands taller now, fixed and neat,
No padding dance, just height complete,
The group/row class whispers its call,
Styling flows through automation's hall,
hops

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing uneven row heights between Mine and Team automation views by pinning row height.
Description check ✅ Passed The description includes a summary of changes and test plan, but omits the standard template sections (Related Issues, Type of Change, Screenshots, Additional Notes).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-kiet-automations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 11, 2026

Greptile Summary

Pins the automation list row height to h-10 (2.5 rem / 40 px) by replacing the previous py-2.5 vertical padding, which caused rows to grow when the Owner column or "paused" badge was present in the Team scope.

  • py-2.5 is removed and h-10 is added to the row className; the grid container already carries items-center, so all cell content stays vertically centered within the fixed 40 px height.
  • Header row (h-8) and data rows (h-10) remain visually distinct, and the change is scoped to a single list-item element.

Confidence Score: 5/5

Safe to merge — the change is a single-line Tailwind class swap on one list row element.

The fix swaps content-driven height (padding + child content) for an explicit fixed height on the row container. The grid already carries items-center, so all cells remain vertically centered. The content inside each cell (small icons, truncated text, a tiny badge) comfortably fits within 40 px, and the header row height is unaffected. No logic, data flow, or component API is touched.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/page.tsx Single-line change replacing py-2.5 vertical padding with h-10 fixed height on the automation list row, aligning row height between Mine and Team scopes; items-center already present on the grid container ensures content stays vertically centered.

Reviews (1): Last reviewed commit: "style(desktop): fix automation row heigh..." | Re-trigger Greptile

@saddlepaddle saddlepaddle merged commit 4622dc5 into main May 11, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant