-
Notifications
You must be signed in to change notification settings - Fork 912
fix(desktop): resolve relative file paths using pty process cwd #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
be1d4b0
fix(desktop): resolve relative file paths using pty process cwd
Kitenite 1d92382
fix(desktop): add logging and error handling for getCwd
Kitenite a22af38
fix(desktop): walk process tree to find shell's actual cwd
Kitenite 3aaa62c
fix(desktop): track cwd from OSC 7 sequences instead of lsof
Kitenite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /** | ||
| * Parse OSC 7 escape sequences to extract the current working directory. | ||
| * OSC 7 format: ESC]7;file://hostname/path BEL (or ESC\) | ||
| * | ||
| * This is emitted by shells when the directory changes. | ||
| */ | ||
|
|
||
| const ESC = "\x1b"; | ||
| const BEL = "\x07"; | ||
|
|
||
| // Match OSC 7 sequences: ESC]7;file://hostname/path followed by BEL or ST (ESC\) | ||
| const OSC7_PATTERN = new RegExp( | ||
| `${ESC}\\]7;file://[^/]*((?:/[^${BEL}${ESC}]*)*)(?:${BEL}|${ESC}\\\\)`, | ||
| "g", | ||
| ); | ||
|
|
||
| /** | ||
| * Parse terminal output data for OSC 7 directory sequences. | ||
| * Returns the last (most recent) directory found, or null if none. | ||
| */ | ||
| export function parseCwd(data: string): string | null { | ||
| let lastMatch: string | null = null; | ||
|
|
||
| for (const match of data.matchAll(OSC7_PATTERN)) { | ||
| const path = match[1]; | ||
| if (path) { | ||
| try { | ||
| lastMatch = decodeURIComponent(path); | ||
| } catch { | ||
| lastMatch = path; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return lastMatch; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 5213
Add Windows support to getCwd method.
The
getCwdmethod correctly implements platform-specific cwd detection for macOS and Linux, but Windows is missing. Since the app targets Windows (evidenced by platform checks throughout the codebase), add a Windows implementation. Windows lacks/proc/[pid]/cwdsymlinks andlsof, so consider using Windows-specific APIs or thewmiccommand as a fallback approach. Ensure the method maintains its current defensive behavior with timeout protection and graceful fallback tosession.cwd.🤖 Prompt for AI Agents