Skip to content

fix(auth): bump MCP OAuth access token TTL to 7d #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
May 10, 2026
+1 −0
Merged

fix(auth): bump MCP OAuth access token TTL to 7d #4365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/auth/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export const auth = betterAuth({
consentPage: `${env.NEXT_PUBLIC_WEB_URL}/oauth/consent`,
allowDynamicClientRegistration: true,
allowUnauthenticatedClientRegistration: true,
accessTokenExpiresIn: 60 * 60 * 24 * 7,
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The arithmetic is correct (604 800 s = 7 days), but a named constant or inline comment would make the intended TTL immediately obvious to future readers without mental arithmetic — especially useful if the value is ever revisited.

Suggested change
accessTokenExpiresIn: 60 * 60 * 24 * 7,
accessTokenExpiresIn: 60 * 60 * 24 * 7, // 7 days
Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/auth/src/server.ts
Line: 205

Comment:
The arithmetic is correct (604 800 s = 7 days), but a named constant or inline comment would make the intended TTL immediately obvious to future readers without mental arithmetic — especially useful if the value is ever revisited.

```suggestion
			accessTokenExpiresIn: 60 * 60 * 24 * 7, // 7 days
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

validAudiences: [
env.NEXT_PUBLIC_API_URL,
`${env.NEXT_PUBLIC_API_URL}/`,
Expand Down
Loading