fix(desktop): open terminal presets as pane instead of new tab by saddlepaddle · Pull Request #430 · superset-sh/superset

saddlepaddle · 2025-12-19T16:00:46Z

Summary

Change default behavior when selecting a terminal preset to add as a split pane in the current tab instead of creating a new tab
Falls back to creating a new tab if no active tab exists
Context menu still offers both "Open as New Tab" and "Open as Pane in Current Tab" options

Test plan

Click preset in sidebar with existing tab → should add pane (split)
Click preset in sidebar with no tabs → should create new tab
Use Cmd+K command dialog to select preset → should add pane
Right-click context menu → should still offer both options

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Preset activation now opens content as a pane within the active tab instead of creating a new tab, improving workflow efficiency. Previous behavior is preserved when no active workspace or tab exists.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Change the default behavior when selecting a terminal preset so it adds as a split pane in the current tab instead of creating a new tab. The context menu still offers both options for users who prefer new tabs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2025-12-19T16:00:58Z

Walkthrough

This PR modifies preset activation behavior in TabsView, redirecting preset selection from opening new tabs to creating panes within the active tab by rerouting through handleSelectPresetAsPane instead of handleSelectPreset in both button handlers and the command dialog.

Changes

Cohort / File(s)	Summary
Preset activation rebinding `apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx`	Changed preset selection to route through `handleSelectPresetAsPane` instead of `handleSelectPreset`, altering preset activation to open as panes within the active tab rather than creating new tabs. Updates both onClick handler and TabsCommandDialog prop. Fallback behavior preserved when no active workspace or tab exists.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Focus areas during review:
- Verify that handleSelectPresetAsPane is correctly defined and handles all necessary pane creation logic
- Confirm fallback behavior works correctly when there is no active workspace or active tab
- Test preset activation through both the button onClick and TabsCommandDialog paths to ensure consistent behavior
- Validate that existing preset functionality is not broken by the routing change

Possibly related PRs

feat(desktop): show preset buttons under New Terminal button #302: Adds preset buttons that call handleSelectPreset; this PR changes those to route through handleSelectPresetAsPane instead.
refactor (Desktop): Make it so when you make a new terminal it makes it in your screen #381: Also modifies TabsView preset behavior to prefer creating panes in the active tab using handleSelectPresetAsPane.
The Abhi Special: Don't add presets + don't create in pane + opencode presets #393: Modifies the same preset/tab creation logic in TabsView with opposing intent (reverting to tab creation).

Poem

🐰 A preset walks into a tab with glee,
But now finds itself in a pane, you see!
No new tab opens—the pane's more neat,
Where presets nestle, their new retreat! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: shifting preset activation from opening a new tab to opening as a pane within the active tab.
Description check	✅ Passed	The description provides a clear summary, test plan, and notes about fallback behavior, though it lacks explicit links to related issues and a formal change type classification.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch frightened-boa-63884b

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b4efd9 and 529412b.

📒 Files selected for processing (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

apps/desktop/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx,js,jsx}: For Electron interprocess communication, ALWAYS use trpc as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/index.tsx

**/*.{ts,tsx}