Skip to content

fix(desktop): stop new-project modal from closing on open #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
May 7, 2026
Merged

fix(desktop): stop new-project modal from closing on open #4192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../_dashboard/components/AddRepositoryModals/components/NewProjectModal/NewProjectModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export function NewProjectModal({
};

return (
<Dialog open={open} onOpenChange={handleOpenChange}>
<Dialog open={open} onOpenChange={handleOpenChange} modal>
<DialogContent className="max-w-[420px]">
<DialogHeader>
<DialogTitle>Clone a repository</DialogTitle>
Expand Down
11 changes: 9 additions & 2 deletions .../components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export function DashboardSidebarHeader({
toast.success("Project ready — open it from the sidebar.");
}
};

const shortcutText = useHotkeyDisplay("NEW_WORKSPACE").text;
const { data: platform } = electronTrpc.window.getPlatform.useQuery();
// Default to Mac while loading so we don't briefly cover the traffic lights.
Expand Down Expand Up @@ -192,7 +193,10 @@ export function DashboardSidebarHeader({
</TooltipTrigger>
<TooltipContent side="right">Add repository</TooltipContent>
</Tooltip>
<DropdownMenuContent align="start">
<DropdownMenuContent
align="start"
onCloseAutoFocus={(event) => event.preventDefault()}
>
<DropdownMenuItem onSelect={() => openNewProject()}>
<HiMiniPlus className="size-4" />
Create new project
Expand Down Expand Up @@ -300,7 +304,10 @@ export function DashboardSidebarHeader({
</TooltipTrigger>
<TooltipContent side="right">Add repository</TooltipContent>
</Tooltip>
<DropdownMenuContent align="end">
<DropdownMenuContent
align="end"
onCloseAutoFocus={(event) => event.preventDefault()}
>
<DropdownMenuItem onSelect={() => openNewProject()}>
<HiMiniPlus className="size-4" />
Create new project
Expand Down
Loading