Skip to content

fix(desktop): return direct-lookup PR/issue regardless of state #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
May 7, 2026
+0 −12
Merged

fix(desktop): return direct-lookup PR/issue regardless of state #4190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/host-service/src/trpc/router/workspace-creation/procedures/search-github-issues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ export const searchGitHubIssues = protectedProcedure
if (issue.url.includes("/pull/")) {
return { issues: [] };
}
if (!input.includeClosed && issue.state !== "open") {
return { issues: [] };
}
return { issues: [issue] };
}
const issues = await ghSearch(
Expand Down Expand Up @@ -145,9 +142,6 @@ export const searchGitHubIssues = protectedProcedure
if (issue.pull_request) {
return { issues: [] };
}
if (!input.includeClosed && issue.state !== "open") {
return { issues: [] };
}
return {
issues: [
{
Expand Down
6 changes: 0 additions & 6 deletions packages/host-service/src/trpc/router/workspace-creation/procedures/search-pull-requests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ export const searchPullRequests = protectedProcedure
if (normalized.isDirectLookup) {
const prNumber = Number.parseInt(effectiveQuery, 10);
const pr = await ghDirectLookup(ctx.execGh, repo, prNumber);
if (!input.includeClosed && pr.state !== "open") {
return { pullRequests: [] };
}
return { pullRequests: [pr] };
}
const pullRequests = await ghSearch(
Expand Down Expand Up @@ -150,9 +147,6 @@ export const searchPullRequests = protectedProcedure
pull_number: prNumber,
});
const state = normalizePullRequestState(pr.state, pr.merged_at);
if (!input.includeClosed && state !== "open") {
return { pullRequests: [] };
}
return {
pullRequests: [
{
Expand Down
Loading